Skip to content

Commit b454943

Browse files
EvilBeaverCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent e1e35dd commit b454943

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,12 @@ jobs:
3030
- name: Extract version from packagedef
3131
id: get_version
3232
run: |
33-
VERSION=$(grep -oP '\.Версия\("\K[^"]+' packagedef)
34-
echo "version=$VERSION" >> $GITHUB_OUTPUT
33+
VERSION=$(grep -oP '\.Версия\("\K[^"]+' packagedef || true)
34+
if [ -z "$VERSION" ]; then
35+
echo "Error: failed to extract version from packagedef."
36+
exit 1
37+
fi
38+
echo "version=$VERSION" >> "$GITHUB_OUTPUT"
3539
echo "Extracted version: $VERSION"
3640
3741
- name: Create dist directory
@@ -41,6 +45,10 @@ jobs:
4145
4246
- name: Build Windows installer with Inno Setup
4347
run: |
48+
if [ ! -f "ovm.exe" ]; then
49+
echo "Error: ovm.exe not found in workspace root. Ensure the 'Build ovm.exe' step completed successfully."
50+
exit 1
51+
fi
4452
docker run --rm -i -v "$GITHUB_WORKSPACE:/work" -w /work amake/innosetup \
4553
/DMyAppVersion="${{ steps.get_version.outputs.version }}" \
4654
install/ovm.iss

install/ovm.iss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ begin
6565
Result := Pos(';' + Uppercase(ParamExpanded) + ';', ';' + Uppercase(OrigPath) + ';') = 0;
6666
// Also check with trailing backslash variant
6767
if Result = True then
68-
Result := Pos(';' + Uppercase(ParamExpanded) + '\' + ';', ';' + Uppercase(OrigPath) + ';') = 0;
68+
Result := Pos(';' + Uppercase(ParamExpanded) + '\' + ';', ';' + Uppercase(OrigPath) + ';') = 0;
6969
end;
7070
7171
procedure CurStepChanged(CurStep: TSetupStep);

0 commit comments

Comments
 (0)