fix: add mime parser for validations

Author: oshankkkk

backend/internal/api/validator/validator.go

@@ -4,6 +4,7 @@ import (
 	"errors"
 	"fmt"
 	"log"
+	"mime"
 	"net/http"
 	"strconv"
 	"strings"
@@ -36,6 +37,17 @@ func formatpath(path string) []string {
 	return strings.Split(path, "/")
 }
 
+func validateJSONContentType(r *http.Request) *httpError {
+	contentType := r.Header.Get("Content-Type")
+	mediaType, _, err := mime.ParseMediaType(contentType)
+	if err != nil || mediaType != "application/json" {
+		log.Printf("invalid content-type: %s", contentType)
+		return &httpError{Status: http.StatusUnsupportedMediaType, Msg: "media not supported"}
+	}
+
+	return nil
+}
+
 func GetNoteValidator(r *http.Request) (int, *httpError) {
 	if err := validatehttpmethod(r, http.MethodGet); err != nil {
 		return 0, &httpError{Status: http.StatusBadRequest, Msg: "method is not supported"}
@@ -110,10 +122,8 @@ func UpdateNoteValidator(r *http.Request) (int, *httpError) {
 		return 0, &httpError{Status: http.StatusMethodNotAllowed, Msg: "method not supported"}
 	}
 
-	contentType := r.Header.Get("Content-Type")
-	if contentType != "application/json" {
-		log.Printf("invalid content-type: %s", contentType)
-		return 0, &httpError{Status: http.StatusUnsupportedMediaType, Msg: "media not supported"}
+	if err := validateJSONContentType(r); err != nil {
+		return 0, err
 	}
 
 	if r.ContentLength == 0 {
@@ -141,10 +151,8 @@ func ImportNotesValidator(r *http.Request) *httpError {
 		return &httpError{Status: http.StatusMethodNotAllowed, Msg: "method not supported"}
 	}
 
-	contentType := r.Header.Get("Content-Type")
-	if contentType != "application/json"  {
-		log.Printf("invalid content-type: %s", contentType)
-		return &httpError{Status: http.StatusUnsupportedMediaType, Msg: "media not supported"}
+	if err := validateJSONContentType(r); err != nil {
+		return err
 	}
 
 	parts := formatpath(r.URL.Path)

backend/internal/api/validator/validator_test.go

@@ -10,7 +10,7 @@ import (
 )
 
 /*
-   GetNoteValidator
+GetNoteValidator
 */
 func TestGetNoteValidator_Success(t *testing.T) {
 	req := httptest.NewRequest(http.MethodGet, "/notes/1", nil)
@@ -30,7 +30,7 @@ func TestGetNoteValidator_InvalidMethod(t *testing.T) {
 }
 
 /*
-   GetNotelistValidator
+GetNotelistValidator
 */
 func TestGetNotelistValidator_Success(t *testing.T) {
 	req := httptest.NewRequest(http.MethodGet, "/notes", nil)
@@ -49,7 +49,7 @@ func TestGetNotelistValidator_InvalidPath(t *testing.T) {
 }
 
 /*
-   CreateNoteValidator
+CreateNoteValidator
 */
 func TestCreateNoteValidator_Success(t *testing.T) {
 	req := httptest.NewRequest(http.MethodPost, "/notes", nil)
@@ -68,7 +68,7 @@ func TestCreateNoteValidator_InvalidMethod(t *testing.T) {
 }
 
 /*
-   DeleteNoteValidator
+DeleteNoteValidator
 */
 func TestDeleteNoteValidator_Success(t *testing.T) {
 	req := httptest.NewRequest(http.MethodDelete, "/notes/2", nil)
@@ -88,7 +88,7 @@ func TestDeleteNoteValidator_InvalidID(t *testing.T) {
 }
 
 /*
-   UpdateNoteValidator
+UpdateNoteValidator
 */
 func TestUpdateNoteValidator_Success(t *testing.T) {
 	body := strings.NewReader(`{"title":"test"}`)
@@ -101,6 +101,17 @@ func TestUpdateNoteValidator_Success(t *testing.T) {
 	assert.Equal(t, 3, id)
 }
 
+func TestUpdateNoteValidator_AcceptsContentTypeParameters(t *testing.T) {
+	body := strings.NewReader(`{"title":"test"}`)
+	req := httptest.NewRequest(http.MethodPatch, "/notes/3", body)
+	req.Header.Set("Content-Type", "application/json; charset=utf-8")
+
+	id, err := UpdateNoteValidator(req)
+
+	assert.Nil(t, err)
+	assert.Equal(t, 3, id)
+}
+
 func TestUpdateNoteValidator_InvalidContentType(t *testing.T) {
 	body := strings.NewReader(`{"title":"test"}`)
 	req := httptest.NewRequest(http.MethodPatch, "/notes/3", body)
@@ -110,3 +121,33 @@ func TestUpdateNoteValidator_InvalidContentType(t *testing.T) {
 
 	assert.NotNil(t, err)
 }
+
+func TestImportNotesValidator_Success(t *testing.T) {
+	body := strings.NewReader(`{"title":"test","content":{}}`)
+	req := httptest.NewRequest(http.MethodPost, "/notes/imports", body)
+	req.Header.Set("Content-Type", "application/json")
+
+	err := ImportNotesValidator(req)
+
+	assert.Nil(t, err)
+}
+
+func TestImportNotesValidator_AcceptsContentTypeParameters(t *testing.T) {
+	body := strings.NewReader(`{"title":"test","content":{}}`)
+	req := httptest.NewRequest(http.MethodPost, "/notes/imports", body)
+	req.Header.Set("Content-Type", "application/json; charset=utf-8")
+
+	err := ImportNotesValidator(req)
+
+	assert.Nil(t, err)
+}
+
+func TestImportNotesValidator_InvalidContentType(t *testing.T) {
+	body := strings.NewReader(`{"title":"test","content":{}}`)
+	req := httptest.NewRequest(http.MethodPost, "/notes/imports", body)
+	req.Header.Set("Content-Type", "text/plain")
+
+	err := ImportNotesValidator(req)
+
+	assert.NotNil(t, err)
+}