Add os_purpose to all images.

[garloff]

Most are generic, the Ubuntu -minimal versions and cirros are minimal, opnsense is custom and flatcar, kubernetes, talos and gardenlinux are capinode.

This implements the changes suggested in PR SCS Standards #970.

Notes:

• The original proposal would have had a specific category for opnsense: network. I had removed it after a discussion, as the intention was to not have categories that we are not using. But we would actually use network, so I'm in favor of adding it back.
• The gardenlinux image is intended as node-image in gardener, I assume? The categorization as capinode image is slightly misleading, as Gardener does not use Cluster-API (which is where capi comes from), though the concept here is still the same AFAIK. I'm neutral as to whether we introduce a category k8snode instead of capinode.
• I'm not sure whether talos should be minimal or capinode (or k8snode).

[garloff]

Comments welcome, @berendt, @mbuechse, @horazont, @depressiveRobot.

[garloff]

Hmm, test fail (flake8?!) looks bogus to me:

 Task Update package lists  failed running on host debian-bookworm
Timeout (32s) waiting for privilege escalation prompt: 

[mbuechse]

I'm wondering whether the code needs to be adapted as well. See this line (and the following):

https://github.com/osism/openstack-image-manager/blob/main/openstack_image_manager/main.py#L361

Something like this should probably be added for the new field as well.

[garloff]

I'm wondering whether the code needs to be adapted as well. See this line (and the following):

https://github.com/osism/openstack-image-manager/blob/main/openstack_image_manager/main.py#L361

Something like this should probably be added for the new field as well.

I don't think so.
What that line does is to add a tag which we recommend. (This one came from CityNetwork/Cleura and is used by their UI.)

| tags             | managed_by_osism, os:ubuntu                                                                                       |
                                       ^^^^^^^^^

[mbuechse]

Sorry, you're right of course. I only faintly remembered (from earlier encounters with the code) that some kind of copying was being done in the script, namely in

https://github.com/osism/openstack-image-manager/blob/main/openstack_image_manager/main.py#L298

and following, but first of all, that doesn't seem to cause a problem here, and second of all, the line that I referenced in the earlier comment was definitely doing what you now said. Sorry for the confusion!

[garloff]

OK, ready from my perspective.

[mbuechse]

Well, lgtm, but let's hear what @berendt has to say.

[garloff]

@berendt, any reason not to proceed?
Standard is solid, will be merged RSN.

[mbuechse]

To be frank, v1.1 is already merged. However, we want to do v2 very soon where this field will be REQUIRED.

[berendt]

Done. Please specify in future if the merge should be completed by a certain date.

[garloff]

Thanks, Christian. It was not exactly urgent, just wanted to ensure there is progress in time before SCS R9 next week.