Skip to content

Improve Spatial MATCHED_OBJECTS for Amenity (icons, 2-way many-to-many hover, additional name, etc)#1884

Open
RZR-UA wants to merge 10 commits into
mainfrom
rzr-ss-web-20jul
Open

Improve Spatial MATCHED_OBJECTS for Amenity (icons, 2-way many-to-many hover, additional name, etc)#1884
RZR-UA wants to merge 10 commits into
mainfrom
rzr-ss-web-20jul

Conversation

@RZR-UA

@RZR-UA RZR-UA commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@RZR-UA
RZR-UA force-pushed the rzr-ss-web-20jul branch from 72fdddb to 8fd2222 Compare July 20, 2026 16:50
@RZR-UA
RZR-UA force-pushed the rzr-ss-web-20jul branch from 8fd2222 to 30941f0 Compare July 20, 2026 16:56

@alisa911 alisa911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR violates some of the rules in CLAUDE.md. Also, please review your own code yourself after the LLM.

Comment thread map/src/menu/search/search/SearchResultItem.jsx Outdated
Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread map/src/menu/search/search/SearchResults.jsx
Comment thread map/src/menu/search/search/CustomInput.jsx
Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread map/src/map/util/MarkerSelectionService.js Outdated
Comment thread map/src/menu/search/search/SearchResultItem.jsx Outdated
Comment thread map/src/util/hooks/map/useSelectMarkerOnMap.js Outdated
Comment thread map/src/util/hooks/map/useSelectMarkerOnMap.js Outdated
Comment thread map/src/util/hooks/map/useSelectMarkerOnMap.js Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enhances OsmAnd Web Map’s spatial search “matched objects” UX by adding richer hover/selection behavior (including many-to-many hover mapping), improved marker/icon handling, and better map navigation via optional bounding boxes.

Changes:

  • Add support for multi-entity hover/selection (hover ids arrays) and applying multiple hovered pins simultaneously.
  • Surface additional matched amenity/name details in search results and enable direct navigation/selection from those matched entries.
  • When bbox metadata is present, prefer fitBounds over point panning for more accurate map framing.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
map/src/util/hooks/map/useSelectMarkerOnMap.js Support multi-id hover matching across layers and apply multiple hover pins.
map/src/menu/search/search/SearchResults.jsx Adjust default search input value selection logic.
map/src/menu/search/search/SearchResultItem.jsx Show additional matched object names and enable navigation/selection from them.
map/src/menu/search/search/CustomInput.jsx Refactor clear-search logic and keep focus after clearing.
map/src/menu/search/search.module.css Add styling for matched object names and hover underline behavior.
map/src/map/util/MarkerSelectionService.js Add applySelectedPins + support restoring multiple updated layers.
map/src/map/util/Clusterizer.js Emit multi-id hover payloads from marker tooltips (many-to-many hover).
map/src/map/layers/SearchLayer.js Create/attach matched amenity markers and fit to bbox when provided.
map/src/infoblock/components/wpt/WptTagsProvider.js Add bbox tag constant for search/map interactions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread map/src/util/hooks/map/useSelectMarkerOnMap.js
Comment thread map/src/util/hooks/map/useSelectMarkerOnMap.js
Comment thread map/src/menu/search/search/SearchResultItem.jsx Outdated
Comment thread map/src/menu/search/search/SearchResultItem.jsx
@RZR-UA
RZR-UA requested a review from alisa911 July 21, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants