fix: support KafkaBackup logging configuration#19
Merged
Conversation
sionsmith
force-pushed
the
fix/kafkabackup-logging-config
branch
from
d40a4d0 to
0763572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.loggingandspec.envfields for KafkaBackup and KafkaRestorespec.logginginto the generated kafka-backup config and appendspec.envto backup/restore job containersosodevops/kafka-backup:v0.15.5Fixes #18
Validation
cargo fmt --all -- --checkcargo testcargo clippy --all-targets --all-features -- -D warningshelm template strimzi-backup-operator deploy/helm/strimzi-backup-operatorcargo run --bin crdgengit diff --checkNotes
The default job image was pinned to
v0.15.3; upstream kafka-backup latest release and Docker tag are nowv0.15.5, so this PR keeps deterministic pinning while updating to the current v0.15 patch release.