fix: reconcile KafkaBackup resources into scheduled CronJobs#42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KafkaBackupspec changesspec.resourcespropagation and the forced apply request0.2.14changelog and release metadataTriage
A clean CronJob updates correctly on current
main. The reported stale state is reproducible when another field manager has claimed the generated container resource fields: changingKafkaBackup.spec.resourcesthen returns four HTTP 409 apply conflicts, leavesstatus.observedGenerationbehind, and keeps the old CronJob values. Deleting the CronJob clears that ownership, which explains the reported workaround.Because the CronJob is generated in full and owned by the
KafkaBackup, reconciliation now force-applies its desired fields. In the same Kind scenario, the fixed operator takes ownership, updates all resource requests and limits, and advances the observed generation without deleting the CronJob.Verification
bash scripts/release-gate.shcargo fmt --all -- --checkcargo check --all-targetscargo test --all-features(92 tests)cargo clippy --all-targets --all-features -- -D warningshelm lintand default chart renderFixes #41