fixed all issues

Author: Mehulantony

bin/rerum_v1.js

@@ -16,9 +16,6 @@ import config from '../config/index.js'
 
 const port = config.PORT ?? 3001
 app.set('port', port)
-
-
-
 /**
  * Create HTTP server.
  */

controllers/bulk.js

@@ -131,17 +131,17 @@ const bulkUpdate = async function (req, res, next) {
         return next(createExpressError(err))
     }
 
-
+    let encountered = []
     const gatekeep = documents.filter(d => {
-    if (!isValidJsonObject(d)) return true
+        if (!isValidJsonObject(d)) return true
         const idcheck = _contextid(d["@context"]) ? (d.id ?? d["@id"]) : d["@id"]
-        if (idcheck) return true
+        if (!idcheck) return true   // Reject items WITHOUT an id (updates need an id)
         return false
     })
     // The empty {}s will cause this error
     if (gatekeep.length > 0) {
         return next(createExpressError({
-            message: "All objects in the body of a `/bulkCreate` must be JSON and must not contain a declared identifier property.",
+            message: "All objects in the body of a `/bulkUpdate` must be JSON and must contain a declared identifier property.",
             status: 400
         }))
     }

package-lock.json

@@ -33,4 +33,4 @@ it("'/bulkCreate' route functions", async () => {
   expect(response.headers["date"]).toBeTruthy()
   expect(response.headers["etag"]).toBeTruthy()
   expect(response.headers["link"]).toBeTruthy()
-}, 20000)
+})

routes/__tests__/bulkCreate.test.js

@@ -37,4 +37,4 @@ it("'/delete' route functions", async () => {
     .then(resp => resp)
     .catch(err => err) 
   expect(response.statusCode).toBe(204)
-}, 20000)
+})

routes/__tests__/delete.test.js

@@ -27,4 +27,4 @@ it("'/history/:id' route functions", async () => {
   expect(response.headers["allow"]).toBeTruthy()
   expect(response.headers["link"]).toBeTruthy()
   expect(Array.isArray(response.body)).toBe(true)
-}, 20000)
+})

routes/__tests__/history.test.js

@@ -37,4 +37,4 @@ it("'/patch' route functions", async () => {
   expect(response.headers["allow"]).toBeTruthy()
   expect(response.headers["link"]).toBeTruthy()
 
-}, 20000)
+})

routes/__tests__/patch.test.js

@@ -39,4 +39,4 @@ it("'/set' route functions", async () => {
       expect(response.headers["etag"]).toBeTruthy()
       expect(response.headers["allow"]).toBeTruthy()
       expect(response.headers["link"]).toBeTruthy()
-}, 20000)
+})

routes/__tests__/set.test.js

@@ -26,4 +26,4 @@ it("'/since/:id' route functions", async () => {
   expect(response.headers["allow"]).toBeTruthy()
   expect(response.headers["link"]).toBeTruthy()
   expect(Array.isArray(response.body)).toBe(true)
-}, 20000)
+})

routes/__tests__/since.test.js

@@ -37,5 +37,5 @@ it("'/unset' route functions", async () => {
     expect(response.headers["etag"]).toBeTruthy()
     expect(response.headers["allow"]).toBeTruthy()
     expect(response.headers["link"]).toBeTruthy()
-}, 20000)
+})