fix:cleanFilename #606

* cleanFilename: make badchars regex less strict

cleanFilename was unnecessarily strict, also removing the legal
characters '+[]
Also, " appeared twice in the regex. And it was missing checks for
control characters.
Finally, /\ should be counted among the illegal characters, not as
whitespace.

See
https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/os/FileUtils.java;l=972?q=isValidFatFilenameChar

* cleanFilename: make whitespace regex configurable

As requested in #606, make it possible to choose how to "clean"
whitespace. Potential options:
- w => '_'
- encodeURIComponent
- w => w (i.e. do nothing -- whitespace isn't forbidden)

Also, simplify the regex -- \s already contains \t and \n, see
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_expressions/Character_classes

Author: hseg

app/utils/utils.common.ts

@@ -14,8 +14,10 @@ export function omit<T extends object, U extends keyof T>(object: T, ...props: U
         .reduce((newObj, key) => Object.assign(newObj, { [key]: object[key] }), {} as any);
 }
 
-export function cleanFilename(str) {
-    return str.replace(/[|?*<\":>+\[\]'"]+/g, '').replace(/[\\\s\t\n\/]+/g, '_');
+export function cleanFilename(str, wsRep=(w => '_')) {
+    return str
+        .replace(/[\x00-\x1f\x7f"*\/:<>?\\|\0x7f]+/g, encodeURIComponent)
+        .replace(/\s/g, wsRep);
 }
 export function getFormatedDateForFilename(value?: number, dateFormat = ApplicationSettings.getString(SETTINGS_FILE_NAME_FORMAT, FILENAME_DATE_FORMAT), clean = true) {
     const now = dayjs(value);