fix: explicit typing for LOGGER and unify usage in engine/tests (#2870)

Author: majd102-p

cve_bin_tool/log.py

@@ -42,5 +42,5 @@ def filter(self, record):
 # Add the handlers to the root logger
 root_logger = logging.getLogger()
 
-LOGGER = logging.getLogger(__package__)
+LOGGER: logging.Logger = logging.getLogger(__package__)
 LOGGER.setLevel(logging.INFO)

test/pages/html_report.py

@@ -1,7 +1,7 @@
 # Copyright (C) 2024 Intel Corporation
 # SPDX-License-Identifier: GPL-3.0-or-later
 
-import logging
+from cve_bin_tool.log import LOGGER
 import os
 from pathlib import Path
 from tempfile import NamedTemporaryFile
@@ -25,7 +25,7 @@ def __init__(
             "w+", delete=False, suffix=".html", encoding="utf-8"
         )
 
-        logger = logging.getLogger()
+        logger = LOGGER
 
         intermediate_report = None
 

test/test_output_engine.py

@@ -15,6 +15,8 @@
 from pathlib import Path
 from unittest.mock import MagicMock, call, patch
 
+from cve_bin_tool.log import LOGGER
+
 from jsonschema import validate
 from jsonschema.exceptions import ValidationError
 from rich.console import Console
@@ -1432,7 +1434,7 @@ def test_output_console_metrics_false(self):
 
     def test_output_file(self):
         """Test file generation logic in output_file"""
-        logger = logging.getLogger()
+        logger = LOGGER
 
         with self.assertLogs(logger, logging.INFO) as cm:
             self.output_engine.output_file(output_type="json")
@@ -1467,7 +1469,7 @@ def test_csv_output_file(self):
 
     def test_output_file_wrapper(self):
         """Test file generation logic in output_file_wrapper"""
-        logger = logging.getLogger()
+        logger = LOGGER
         self.output_engine.filename = "test-report"
 
         with self.assertLogs(logger, logging.INFO) as cm:
@@ -1507,7 +1509,7 @@ def test_output_file_filename_already_exists(self):
         with open("testfile.csv", "w") as f:
             f.write("testing")
 
-        logger = logging.getLogger()
+        logger = LOGGER
 
         # setup the context manager
         with self.assertLogs(logger, logging.INFO) as cm:
@@ -1545,7 +1547,7 @@ def test_output_file_incorrect_filename(self):
         # update the filename in output_engine
         self.output_engine.filename = "/not/a/good_filename"
 
-        logger = logging.getLogger()
+        logger = LOGGER
 
         # setup the context manager
         with self.assertLogs(logger, logging.INFO) as cm: