Skip to content

test: add curl RPM test for Alma Linux#5716

Closed
AVI-SHUKLA1110 wants to merge 1 commit into
ossf:mainfrom
AVI-SHUKLA1110:alma-linux-investigation
Closed

test: add curl RPM test for Alma Linux#5716
AVI-SHUKLA1110 wants to merge 1 commit into
ossf:mainfrom
AVI-SHUKLA1110:alma-linux-investigation

Conversation

@AVI-SHUKLA1110

Copy link
Copy Markdown

Adds a test for curl RPM package from Alma Linux 8.

Package scanned: curl-7.61.1-34.el8_10.10.x86_64.rpm
Source: https://repo.almalinux.org/almalinux/8/BaseOS/x86_64/os/Packages/curl-7.61.1-34.el8_10.10.x86_64.rpm

What I did

  • Downloaded the curl RPM from Alma Linux 8 BaseOS repository
  • Ran cve-bin-tool against the package
  • Tool correctly detected haxx.curl version 7.61.1
  • Found 42 CVEs (9 HIGH, 24 MEDIUM, 9 LOW) as expected
  • Added the package to package_test_data in test/test_data/curl.py
  • Added condensed download to test/condensed-downloads/

Why

No existing RPM test covered Alma Linux (el8).
Existing tests covered fc20, fc34, fc30 (Fedora) and el7 (RHEL 7)
but not el8/Alma Linux.
Adds a test for curl RPM package from Alma Linux 8.

Package scanned: curl-7.61.1-34.el8_10.10.x86_64.rpm
Source: https://repo.almalinux.org/almalinux/8/BaseOS/x86_64/os/Packages/curl-7.61.1-34.el8_10.10.x86_64.rpm

What I did

  • Downloaded the curl RPM from Alma Linux 8 BaseOS repository
  • Ran cve-bin-tool against the package
  • Tool correctly detected haxx.curl version 7.61.1
  • Found 42 CVEs (9 HIGH, 24 MEDIUM, 9 LOW) as expected
  • Added the package to package_test_data in test/test_data/curl.py
  • Added condensed download to test/condensed-downloads/

Why

No existing RPM test covered Alma Linux (el8).
Existing tests covered fc20, fc34, fc30 (Fedora) and el7 (RHEL 7)
but not el8/Alma Linux.

fixes #[2761]

Signed-off-by: AVI-SHUKLA1110 <ashikla693@gmail.com>
@ffontaine

Copy link
Copy Markdown
Collaborator

Thank you for this PR. I have two comments:

  • Black should be run on test_data/curl.py.
  • What is the purpose of this PR if the checker already works well with the Alma Linux package? It seems to mainly add a new test file without significant added value. It would be more interesting to work on other Alma Linux package (e.g. feat(checker): add lvm2 checker for Alma Linux support #5674)

@VanitasCodes

Copy link
Copy Markdown
Contributor

I too think @ffontaine has a fair point. Since curl detection already works with Alma Linux packages, adding a 314 KB binary to the repo just to test something that's already working doesn't add much value. It might be worth closing this and focusing on packages that actually need new checkers.

@ffontaine ffontaine closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants