fix: explicit typing for LOGGER and restore unified logger usage (#2870)#5724
Open
majd102-p wants to merge 5 commits into
Open
fix: explicit typing for LOGGER and restore unified logger usage (#2870)#5724majd102-p wants to merge 5 commits into
majd102-p wants to merge 5 commits into
Conversation
…#2870) Signed-off-by: majd102-p <32015333020@std.bau.edu.jo>
majd102-p
force-pushed
the
fix-logger-type-2870
branch
from
196406d to
acbef20
Compare
Signed-off-by: Majd Ayoub <majd.redmi102@gmail.com>
majd102-p
force-pushed
the
fix-logger-type-2870
branch
from
826e557 to
3f999d8
Compare
Author
|
Updated the PR: I have fixed the isort formatting and ensured all commits are DCO signed-off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the type-checking issues in #2870:
logging.Loggertype hint to the globalLOGGERinlog.pyto satisfymypy.output_engine/html.pyto use the shared packageLOGGER.test/pages/html_report.pyandtest/test_output_engine.pyfor consistency.This ensures full type safety while following the maintainer's preference for a centralized logging solution.