Add explicit Logger type annotation for LOGGER#5780
Open
Anand-Krishnan-PK wants to merge 1 commit into
Open
Conversation
Add an explicit Logger type annotation to LOGGER in cve_bin_tool.log to improve type checking and address the discussion in ossf#2870. Signed-off-by: Anand Krishnan PK <anandkrishnanpk20031@gmail.com>
Anand-Krishnan-PK
force-pushed
the
patch-1
branch
from
1f8da9b to
8481522
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an explicit
Loggertype annotation toLOGGERincve_bin_tool/log.py.Based on the discussion in #2870, this aims to improve static type checking by making the type of the shared logger instance explicit.