You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks reasonable to me. Perhaps it would be wise to clarify whether the full name of the Reservoir package is desired (i.e., @leanprover-community/mathlib vs just mathlib)?
@eric-wieser I think the @ is a useful marker for disambiguation. But, if the context is unambiguous, it is fine to drop it. As it is not a proper part of the package's name, it should probably not be included in the name here.
So leanprover-community/mathlib would be your preferred format for name? Or @leanprover-community/mathlib to disamguate from the github repo name (which is of course different!)
@eric-wieser Since the name is already contextually constrained by the ecosystem (Lean), the bare name seems fine. If you wanted to allow either the repository name or the package name as the name, then using the @ as a disambiguator would be reasonable. With the current draft, though, this is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reservoir here refers to https://reservoir.lean-lang.org/
Let's check with @tydeu, the maintainer thereof, that the verbiage is correct here.