Changed github logo on member page to be a generic git icon#308
Open
csrs wants to merge 3 commits into
Open
Conversation
alexdor
reviewed
Oct 13, 2019
| <GitCommit className="member__icon" /> | ||
| <TextInput | ||
| label="Github Url" | ||
| label="Github/Gitlab/Bitbucket Url" |
Member
There was a problem hiding this comment.
Maybe it would be better if we wrote something like "Git server url (for example Github, Gitlab or Bitbucket)" ?
@bacharakis thoughts?
Collaborator
Author
There was a problem hiding this comment.
I'll update it to use that language... it's more specific
alexdor
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to Issue #287
Currently, the GitHub icon appears regardless of if the URL is GitHub or Gitlab. The issue asked if we can make the icon change depending on what type of URL is entered. My idea is to instead change the GitHub icon to a generic git icon, so that GitHub, GitLab, Bitbucket are all equal options and the code or UI doesn't need another if/else logic or text box to do things differently depending on what is entered. I think this would keep the code cleaner.