Skip to content

Commit b2a6364

Browse files
Merge pull request #52 from ostdotcom/develop
merging develop to release-2.0
2 parents e4988cd + 0ce6a5e commit b2a6364

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ language: php
33
sudo: required
44
branches:
55
only:
6-
- master
76
- develop
87
- /^release-.*/
98
notifications:

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
[OST PHP SDK v2.0.0](https://github.com/ostdotcom/ost-sdk-php/tree/v2.0.0)
22
---
3-
* Released OST V2 API's
4-
* Cleaned up code for the deprecated V1 & V1.1 API's
3+
* OST API V2 interaction layer implementation.
4+
* Removed API V0 and V1 support.
5+
* [README.md](README.md) has API V2 usage instructions
56

67
[OST PHP SDK v1.1.1](https://github.com/ostdotcom/ost-sdk-php/tree/v1.1.1)
78
---

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ $params['apiBaseUrl']='';
6868
// The config field is optional
6969
$configParams = array();
7070
// This is the timeout in seconds for which the socket connection will remain open
71-
$configParams["timeout"] = 15;
71+
$configParams["timeout"] = 60;
7272
$params["config"] = $configParams;
7373

7474
$ostObj = new OSTSdk($params);
@@ -336,8 +336,8 @@ $transferAmount = array("150000000000000000", "100000000000000000");
336336
$rawCallData['method'] = 'pay';
337337
$tokenHolderSender = '0xa9632350057c2226c5a10418b1c3bc9acdf7e2ee';
338338
$payCurrencyCode = 'USD';
339-
$ostToUsdInWei = '23757000000000000'; // get price-point response
340-
$rawCallData['parameters'] = array($tokenHolderSender, $transferTo, $transferAmount, $payCurrencyCode, $ostToUsdInWei);
339+
$ostToUsd = '23757000000000000'; // get price-point response
340+
$rawCallData['parameters'] = array($tokenHolderSender, $transferTo, $transferAmount, $payCurrencyCode, $ostToUsd);
341341
$executeParams['raw_calldata'] = json_encode($rawCallData);
342342
//$executeParams['meta_property'] = $metaPropertyParams;
343343
$response = $transactionsService->execute($executeParams)->wait();

src/Lib/Request.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public function __construct(array $params)
4747
$this->apiSecret = $params['apiSecret'];
4848

4949
$this->baseUrl = $this->sanitizeApiBaseUrl($params['apiBaseUrl']);
50-
$this->timeout = 10;
50+
$this->timeout = 60;
5151
if (array_key_exists("config", $params)) {
5252
$config = $params["config"];
5353
if (array_key_exists("timeout", $config) && is_array($config)) {
@@ -357,8 +357,8 @@ private function getCommonRequestParams()
357357
'Content-Type' => 'application/x-www-form-urlencoded'
358358
],
359359
'http_errors' => false,
360-
'connect_timeout' => 10,
361-
'open_timeout' => 10
360+
'connect_timeout' => $this->timeout,
361+
'open_timeout' => $this->timeout
362362
];
363363

364364
}

0 commit comments

Comments
 (0)