Modernize currency API by otherguy · Pull Request #123 · otherguy/php-currency-api

otherguy · 2026-04-27T09:42:24Z

Modernizes php-currency-api for v2 with a stricter PHP 8.3+ baseline, PSR HTTP abstractions, precise decimal math, updated provider support, and a refreshed test/tooling/docs surface.

Require PHP 8.3+ and add strict types throughout.
Replace hard-wired Guzzle usage with PSR-18 client and PSR-17 request factory support.
Add Currency backed enum while keeping Symbol as a deprecation shim.
Switch conversion rates from floats to brick/math BigDecimal.
Add new built-in drivers:
- frankfurter
- currencyapi
- fastforex
Rewrite exchangeratesapi for APILayer’s current endpoint and implement conversion support.
Add instance-based DriverFactory registration while preserving DriverFactory::make().
Add modern CI/tooling:
- GitHub Actions
- Pint
- PHPStan
- Rector
- PHPUnit 12
Refresh README, Changelog, contributor docs, upgrade notes, and examples.

qltysh · 2026-04-27T09:45:18Z

2 new issues

Tool	Category	Rule	Count
qlty	Duplication	Found 17 lines of similar code in 2 locations (mass = 163)	2

qltysh · 2026-04-27T10:49:58Z

+        }
+
+        $response = $this->apiRequest('latest', [
+          'base'    => $this->getBaseCurrency(),


Wrong amount of left-padding spaces(want multiple of 4) [editorconfig-checker:indent_size]

qltysh · 2026-04-27T10:59:37Z

+     *
+     * @return array<string, BigDecimal|float|int|string>
+     */
+    protected function responseRates(array $response, string $key, string $provider): array


Method Otherguy\Currency\Drivers\BaseCurrencyDriver::responseRates() has invalid return type Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T10:59:37Z

+
+        $normalised = [];
+        foreach ($rates as $currency => $rate) {
+            if (!$rate instanceof BigDecimal && !is_float($rate) && !is_int($rate) && !is_string($rate)) {


Class Brick\Math\BigDecimal not found. [phpstan:class.notFound]

qltysh · 2026-04-27T10:59:37Z

+            throw new ApiException('CurrencyAPI response did not contain a converted value.');
+        }
+
+        $rate = BigDecimal::of((string) $converted)


Call to static method of() on an unknown class Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T10:59:38Z

+        }
+
+        $rate = BigDecimal::of((string) $converted)
+          ->dividedBy(BigDecimal::of((string) $this->amount), ConversionResult::DEFAULT_SCALE, RoundingMode::HALF_UP);


Found 2 issues:

1. Access to constant HALF_UP on an unknown class Brick\Math\RoundingMode. [phpstan:class.notFound]

2. Call to static method of() on an unknown class Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T10:59:38Z

+     *
+     * @return array<string, BigDecimal|float|int|string>
+     */
+    private function ratesFromData(mixed $data): array


Method Otherguy\Currency\Drivers\CurrencyApi::ratesFromData() has invalid return type Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T10:59:39Z

+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+class CurrencyTest extends TestCase


Class Otherguy\Currency\Tests\CurrencyTest extends unknown class PHPUnit\Framework\TestCase. [phpstan:class.notFound]

qltysh · 2026-04-27T10:59:39Z

+
+class CurrencyTest extends TestCase
+{
+    #[Test]


Attribute class PHPUnit\Framework\Attributes\Test does not exist. [phpstan:attribute.notFound]

qltysh · 2026-04-27T10:59:39Z

+    #[Test]
+    public function exposes_all_supported_currency_cases(): void
+    {
+        $this->assertCount(167, Currency::cases());


Call to an undefined method Otherguy\Currency\Tests\CurrencyTest::assertCount(). [phpstan:method.notFound]

qltysh · 2026-04-27T10:59:39Z

+        $this->assertCount(167, Currency::cases());
+    }
+
+    #[Test]


Attribute class PHPUnit\Framework\Attributes\Test does not exist. [phpstan:attribute.notFound]

qltysh · 2026-04-27T10:59:39Z

+    #[Test]
+    public function backed_value_matches_iso_code(): void
+    {
+        $this->assertSame('USD', Currency::USD->value);


Call to an undefined method Otherguy\Currency\Tests\CurrencyTest::assertSame(). [phpstan:method.notFound]

qltysh · 2026-04-27T11:03:05Z

+     *
+     * @return array<string, BigDecimal|float|int|string>
+     */
+    protected function responseRates(array $response, string $key, string $provider): array


Method Otherguy\Currency\Drivers\BaseCurrencyDriver::responseRates() has invalid return type Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T11:03:05Z

+
+        $normalised = [];
+        foreach ($rates as $currency => $rate) {
+            if (!$rate instanceof BigDecimal && !is_float($rate) && !is_int($rate) && !is_string($rate)) {


Class Brick\Math\BigDecimal not found. [phpstan:class.notFound]

qltysh · 2026-04-27T11:03:05Z

+            throw new ApiException('CurrencyAPI response did not contain a converted value.');
+        }
+
+        $rate = BigDecimal::of((string) $converted)


Call to static method of() on an unknown class Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T11:03:05Z

+        }
+
+        $rate = BigDecimal::of((string) $converted)
+          ->dividedBy(BigDecimal::of((string) $this->amount), ConversionResult::DEFAULT_SCALE, RoundingMode::HALF_UP);


Found 2 issues:

1. Access to constant HALF_UP on an unknown class Brick\Math\RoundingMode. [phpstan:class.notFound]

2. Call to static method of() on an unknown class Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T11:03:05Z

+     *
+     * @return array<string, BigDecimal|float|int|string>
+     */
+    private function ratesFromData(mixed $data): array


Method Otherguy\Currency\Drivers\CurrencyApi::ratesFromData() has invalid return type Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T11:03:06Z

+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+class CurrencyTest extends TestCase


Class Otherguy\Currency\Tests\CurrencyTest extends unknown class PHPUnit\Framework\TestCase. [phpstan:class.notFound]

qltysh · 2026-04-27T11:03:06Z

+
+class CurrencyTest extends TestCase
+{
+    #[Test]


Attribute class PHPUnit\Framework\Attributes\Test does not exist. [phpstan:attribute.notFound]

qltysh · 2026-04-27T11:03:06Z

+    #[Test]
+    public function exposes_all_supported_currency_cases(): void
+    {
+        $this->assertCount(167, Currency::cases());


Call to an undefined method Otherguy\Currency\Tests\CurrencyTest::assertCount(). [phpstan:method.notFound]

qltysh · 2026-04-27T11:03:06Z

+        $this->assertCount(167, Currency::cases());
+    }
+
+    #[Test]


Attribute class PHPUnit\Framework\Attributes\Test does not exist. [phpstan:attribute.notFound]

qltysh · 2026-04-27T11:03:06Z

+    #[Test]
+    public function backed_value_matches_iso_code(): void
+    {
+        $this->assertSame('USD', Currency::USD->value);


Call to an undefined method Otherguy\Currency\Tests\CurrencyTest::assertSame(). [phpstan:method.notFound]

- Add open graph preview image in PNG and SVG formats. - Create `resources/README.md` to document resource folder contents. - Remove obsolete PSD file.

- Update README to reflect new API wrapper description and upgrade notes. - Add UPGRADING.md file with detailed upgrade instructions from 1.x to 2.x.

- Update CI workflow to trigger on `main` branch only. - Change push instructions in CONTRIBUTING.md to use `main` branch. - Update README badges to reflect `main` branch for CI and coverage.

- Update GitHub Actions workflow to include linting jobs. - Modify dependabot configuration for improved dependency updates. - Add linting configuration files for Markdown and YAML.

qltysh · 2026-04-27T12:11:31Z

+        with:
+          persist-credentials: false
+      - name: Markdown Lint
+        uses: DavidAnson/markdownlint-cli2-action@v23


unpinned action reference [zizmor:zizmor/unpinned-uses]

qltysh · 2026-04-27T12:11:31Z

+          config: ".markdownlint.yaml"
+
+      - name: YAML Lint
+        uses: karancode/yamllint-github-action@master


unpinned action reference [zizmor:zizmor/unpinned-uses]

qltysh · 2026-04-27T12:11:31Z

+     *
+     * @return array<string, BigDecimal|float|int|string>
+     */
+    protected function responseRates(array $response, string $key, string $provider): array


Method Otherguy\Currency\Drivers\BaseCurrencyDriver::responseRates() has invalid return type Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T12:11:31Z

+
+        $normalised = [];
+        foreach ($rates as $currency => $rate) {
+            if (!$rate instanceof BigDecimal && !is_float($rate) && !is_int($rate) && !is_string($rate)) {


Class Brick\Math\BigDecimal not found. [phpstan:class.notFound]

qltysh · 2026-04-27T12:11:31Z

+            throw new ApiException('CurrencyAPI response did not contain a converted value.');
+        }
+
+        $rate = BigDecimal::of((string) $converted)


Call to static method of() on an unknown class Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T12:11:33Z

+    /**
+     * @throws MathException
+     */
+    private function toBigDecimal(BigDecimal|float|int|string $value): BigDecimal


Found 3 issues:

1. Method Otherguy\Currency\Results\ConversionResult::toBigDecimal() has invalid return type Brick\Math\BigDecimal. [phpstan:class.notFound]

2. PHPDoc tag @throws with type Brick\Math\Exception\MathException is not subtype of Throwable [phpstan:throws.notThrowable]

3. Parameter $value of method Otherguy\Currency\Results\ConversionResult::toBigDecimal() has invalid type Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T12:11:33Z

+     */
+    private function toBigDecimal(BigDecimal|float|int|string $value): BigDecimal
+    {
+        return $value instanceof BigDecimal ? $value : BigDecimal::of($value);


Found 2 issues:

1. Call to static method of() on an unknown class Brick\Math\BigDecimal. [phpstan:class.notFound]

2. Class Brick\Math\BigDecimal not found. [phpstan:class.notFound]

qltysh · 2026-04-27T12:11:33Z

+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+class CurrencyTest extends TestCase


Class Otherguy\Currency\Tests\CurrencyTest extends unknown class PHPUnit\Framework\TestCase. [phpstan:class.notFound]

qltysh · 2026-04-27T12:11:33Z

+
+class CurrencyTest extends TestCase
+{
+    #[Test]


Attribute class PHPUnit\Framework\Attributes\Test does not exist. [phpstan:attribute.notFound]

qltysh · 2026-04-27T12:11:33Z

+    #[Test]
+    public function exposes_all_supported_currency_cases(): void
+    {
+        $this->assertCount(167, Currency::cases());


Call to an undefined method Otherguy\Currency\Tests\CurrencyTest::assertCount(). [phpstan:method.notFound]

…rivers - Add triage rules to Qlty configuration. - Update `CONTRIBUTING.md` with prerequisites and setup instructions. - Add `phpstan/phpstan-phpunit` dependency to `composer.json`. - Create Lefthook configuration for automated checks. - Refactor currency driver methods to improve structure and usage. - Extend currency enum with comprehensive currency names. - Introduce `MockHttpClientException` for better error handling in tests. - Update various tests for new and modified functionality.

qltysh · 2026-04-27T12:36:29Z

+
+        $response = $this->apiRequest('convert', $params);
+
+        $rate = BigDecimal::of($this->responseString($response, 'result', static::class))


Call to static method of() on an unknown class Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T12:36:29Z

+        $response = $this->apiRequest('convert', $params);
+
+        $rate = BigDecimal::of($this->responseString($response, 'result', static::class))
+          ->dividedBy(BigDecimal::of((string) $this->amount), ConversionResult::DEFAULT_SCALE, RoundingMode::HALF_UP);


Found 2 issues:

1. Access to constant HALF_UP on an unknown class Brick\Math\RoundingMode. [phpstan:class.notFound]

2. Call to static method of() on an unknown class Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T12:36:29Z

+     *
+     * @return array<string, BigDecimal|float|int|string>
+     */
+    protected function responseRates(array $response, string $key, string $provider): array


Method Otherguy\Currency\Drivers\BaseCurrencyDriver::responseRates() has invalid return type Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T12:36:29Z

+
+        $normalised = [];
+        foreach ($rates as $currency => $rate) {
+            if (!$rate instanceof BigDecimal && !is_float($rate) && !is_int($rate) && !is_string($rate)) {


Class Brick\Math\BigDecimal not found. [phpstan:class.notFound]

qltysh · 2026-04-27T12:36:29Z

+            throw new ApiException('CurrencyAPI response did not contain a converted value.');
+        }
+
+        $rate = BigDecimal::of((string) $converted)


Call to static method of() on an unknown class Brick\Math\BigDecimal. [phpstan:class.notFound]

qltysh · 2026-04-27T12:36:31Z

+        $this->assertSame('United States Dollar', Currency::USD->displayName());
+    }
+
+    #[Test]


Attribute class PHPUnit\Framework\Attributes\Test does not exist. [phpstan:attribute.notFound]

qltysh · 2026-04-27T12:36:31Z

+    #[Test]
+    public function try_from_code_returns_matching_case(): void
+    {
+        $this->assertSame(Currency::USD, Currency::tryFromCode('USD'));


Call to an undefined method Otherguy\Currency\Tests\CurrencyTest::assertSame(). [phpstan:method.notFound]

qltysh · 2026-04-27T12:36:31Z

+    public function try_from_code_returns_matching_case(): void
+    {
+        $this->assertSame(Currency::USD, Currency::tryFromCode('USD'));
+        $this->assertNull(Currency::tryFromCode('XYZ'));


Call to an undefined method Otherguy\Currency\Tests\CurrencyTest::assertNull(). [phpstan:method.notFound]

qltysh · 2026-04-27T12:36:31Z

+        $this->assertNull(Currency::tryFromCode('XYZ'));
+    }
+
+    #[Test]


Attribute class PHPUnit\Framework\Attributes\Test does not exist. [phpstan:attribute.notFound]

qltysh · 2026-04-27T12:36:31Z

+    #[Test]
+    public function code_helper_coerces_strings_and_enum_values(): void
+    {
+        $this->assertSame('USD', Currency::code('USD'));


Call to an undefined method Otherguy\Currency\Tests\CurrencyTest::assertSame(). [phpstan:method.notFound]

…stan - Apply #[Override] to driver methods so Rector's dry-run gate passes on PHP 8.3+ - Switch CI coverage driver from xdebug to pcov (matches local docs, faster) - Disable qlty's phpstan plugin: it runs without composer autoload and produces ~100 false positives for PSR-18 / PHPUnit attribute classes; CI's phpstan run already covers this with the project's autoloader - Document local pcov/xdebug install in CONTRIBUTING.md so phpunit's failOnWarning config doesn't surprise contributors

qltysh · 2026-04-27T12:52:56Z

+        $this->assertSame('2013-12-24', $result->getDate());
+        $this->assertSame('1.636492', (string) $result->rate(Currency::USD));
+        $this->assertSame('1.196476', (string) $result->rate(Currency::EUR));
+        $this->assertSame('1.739516', (string) $result->rate(Currency::CAD));


Found 17 lines of similar code in 2 locations (mass = 163) [qlty:similar-code]

qltysh · 2026-04-27T12:52:56Z

+        $this->assertSame('2001-02-16', $result->getDate());
+        $this->assertSame('3.67246', (string) $result->rate(Currency::AED));
+        $this->assertSame('144.529793', (string) $result->rate(Currency::ALL));
+        $this->assertSame('1.79', (string) $result->rate(Currency::ANG));


Found 16 lines of similar code in 2 locations (mass = 163) [qlty:similar-code]

Override the lint driver to install composer deps (so PSR-18, PHPUnit attributes, and project classes resolve), point phpstan at the project's autoloader, and keep phpstan.neon at the project root so its relative ignoreErrors paths still match. Restores PR-comment mode without false positives — verified locally via `qlty check --filter=phpstan`.

qltysh · 2026-04-27T13:13:46Z

+        $this->assertSame('2013-12-24', $result->getDate());
+        $this->assertSame('1.636492', (string) $result->rate(Currency::USD));
+        $this->assertSame('1.196476', (string) $result->rate(Currency::EUR));
+        $this->assertSame('1.739516', (string) $result->rate(Currency::CAD));


Found 17 lines of similar code in 2 locations (mass = 163) [qlty:similar-code]

qltysh · 2026-04-27T13:13:46Z

+        $this->assertSame('2001-02-16', $result->getDate());
+        $this->assertSame('3.67246', (string) $result->rate(Currency::AED));
+        $this->assertSame('144.529793', (string) $result->rate(Currency::ALL));
+        $this->assertSame('1.79', (string) $result->rate(Currency::ANG));


Found 16 lines of similar code in 2 locations (mass = 163) [qlty:similar-code]

Modernize currency API for v2

bba1455

qltysh Bot reviewed Apr 27, 2026

View reviewed changes

Fix CI dependency matrix

08b9912

qltysh Bot reviewed Apr 27, 2026

View reviewed changes

otherguy force-pushed the v2-modernization branch from cdc2604 to 2a858d0 Compare April 27, 2026 10:48

qltysh Bot reviewed Apr 27, 2026

View reviewed changes

otherguy force-pushed the v2-modernization branch from 2a858d0 to 66b5ed5 Compare April 27, 2026 10:56

qltysh Bot reviewed Apr 27, 2026

View reviewed changes

Fix qlty review findings

7c25f37

otherguy force-pushed the v2-modernization branch from 66b5ed5 to 7c25f37 Compare April 27, 2026 11:00

otherguy self-assigned this Apr 27, 2026

otherguy added the enhancement label Apr 27, 2026

qltysh Bot reviewed Apr 27, 2026

View reviewed changes

otherguy added 4 commits April 27, 2026 19:13

Update README and add resource files for open graph image assets

f02d469

- Add open graph preview image in PNG and SVG formats. - Create `resources/README.md` to document resource folder contents. - Remove obsolete PSD file.

Update README and add UPGRADING guide for version 2.0 changes

bb66b6b

- Update README to reflect new API wrapper description and upgrade notes. - Add UPGRADING.md file with detailed upgrade instructions from 1.x to 2.x.

Update CI workflow and documentation for main branch usage

8a62eec

- Update CI workflow to trigger on `main` branch only. - Change push instructions in CONTRIBUTING.md to use `main` branch. - Update README badges to reflect `main` branch for CI and coverage.

Update GitHub Actions workflows and dependency configuration

3621347

- Update GitHub Actions workflow to include linting jobs. - Modify dependabot configuration for improved dependency updates. - Add linting configuration files for Markdown and YAML.

qltysh Bot reviewed Apr 27, 2026

View reviewed changes

otherguy merged commit 7fd19f8 into main Apr 27, 2026
6 checks passed

otherguy deleted the v2-modernization branch April 27, 2026 13:17


		$response = $this->apiRequest('convert', $params);

		$rate = BigDecimal::of($this->responseString($response, 'result', static::class))

Conversation

otherguy commented Apr 27, 2026

Uh oh!

qltysh Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2 new issues

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Apr 27, 2026

Choose a reason for hiding this comment

qltysh Bot commented Apr 27, 2026 •

edited

Loading