OD-1730: Switch to using ruff for linting

Author: hlieberman

.github/workflows/python-app-linux.yml

@@ -34,14 +34,11 @@ jobs:
         shell: bash
         run: |
           python -m pip install --upgrade pip
-          pip install flake8 pytest
+          pip install pytest
           if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-      - name: Lint with flake8
+      - name: Lint with ruff
         run: |
-          # stop the build if there are Python syntax errors or undefined names
-          flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
-          # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-          flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+          ruff check .
       - name: Test with pytest
         run: |
           pytest

.github/workflows/python-app-macos-windows.yml

@@ -27,14 +27,11 @@ jobs:
         shell: bash
         run: |
           python -m pip install --upgrade pip
-          pip install flake8 pytest
+          pip install pytest
           if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-      - name: Lint with flake8
+      - name: Lint with ruff
         run: |
-          # stop the build if there are Python syntax errors or undefined names
-          flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
-          # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-          flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+          ruff check .
       - name: Test with pytest - exclude MySQL integration tests
         run: |
           pytest --ignore "opendoors/tests/test_sql_db.py" --ignore "efiction/tests/test_metadata.py"

opendoors/mysql.py

@@ -159,7 +159,7 @@ def dump_database(self, database: str, destination_filepath: str):
                     f.write(f"INSERT INTO {database}.`{str(table)}` ({column_names}) VALUES \n")
                 field_arr = []
                 for field in row:
-                    if type(row[field]) == str or type(row[field]) == datetime.datetime:
+                    if type(row[field]) == str or type(row[field]) == datetime.datetime:  # noqa: E721
                         field_arr.append(self.conn.escape(row[field]))
                     elif row[field] is None:
                         field_arr.append("NULL")
@@ -198,7 +198,7 @@ def __del__(self):
         """
         try:
             self.conn.close()
-        except:
+        except:  # noqa: E722
             pass
 
 

requirements.txt

@@ -16,6 +16,7 @@ pycparser==2.20
 PyMySQL==0.10.1
 pyparsing==2.4.7
 pytest==6.1.0
+ruff==0.1.3
 shutils==0.1.0
 six==1.15.0
 sqlparse==0.3.1

start.py

@@ -46,7 +46,7 @@ def save_config_and_exit():
         code_name = sys.argv[1]
     else:
         code_name = None
-        while (code_name == None or any([x not in "qwertyuiopasdfghjklzxcvbnm" for x in code_name])):
+        while (code_name == None or any([x not in "qwertyuiopasdfghjklzxcvbnm" for x in code_name])):  # noqa: E711
             code_name = input(
                 "Please provide a short, lowercase code name with no spaces or punctuation for the archive "
                 "you are processing (and make a note of it as you'll need it in future!):\n>> ")