OD-2139: Fix skipping tags on damaged imports#41
Merged
Conversation
hlieberman
force-pushed
the
master
branch
2 times, most recently
from
f144dfd to
e7f2039
Compare
brianna-dardin
requested changes
Mar 15, 2026
Member
brianna-dardin
left a comment
brianna-dardin
left a comment
There was a problem hiding this comment.
I think this all looks good, though one of the workflow actions failed due to a unit test failure, the one at efiction/tests/test_metadata.py. Do you think you could also update that as well?
hlieberman
force-pushed
the
master
branch
2 times, most recently
from
b6f493e to
9e5c69e
Compare
Previously, the system would skip importing the entire class of tags when a malformed tag was found in any story. This patch changes it to error on malformed tags, but allow the non-standard (mostly) all string tag format. In addition, we now warn when importing stories that have tags not in the tag table.
brianna-dardin
approved these changes
Mar 16, 2026
Member
brianna-dardin
left a comment
brianna-dardin
left a comment
There was a problem hiding this comment.
Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the system would skip importing the entire class of tags when a malformed tag was found in any story. This patch changes it to error on malformed tags, but allow the non-standard (mostly) all string tag format.
In addition, we now warn when importing stories that have tags not in the tag table.