Skip to content

Commit ad3ba78

Browse files
committed
AO3-7397 Standardise skin preview flash
Use <br /> to form the multiline flash message for skin previews, rather than an array which turns it into an unordered list with <ul>
1 parent 00e828a commit ad3ba78

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

app/controllers/skins_controller.rb

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -134,11 +134,12 @@ def preview
134134
redirect_to user_skins_path(current_user) and return
135135
end
136136

137-
flash[:notice] = []
138-
flash[:notice] << t(".skin_title", title: @skin.title)
139-
flash[:notice] << t(".remove_skin")
140-
flash[:notice] << t(".tip", site_skin_id: @skin.id)
141-
flash[:notice] << helpers.link_to(t(".return_to_skin"), skin_path(@skin), class: "action")
137+
flash[:notice] = [
138+
t(".skin_title", title: @skin.title),
139+
t(".remove_skin"),
140+
t(".tip", site_skin_id: @skin.id),
141+
helpers.link_to(t(".return_to_skin"), skin_path(@skin), class: "action")
142+
].join('<br />')
142143
redirect_to "#{ArchiveConfig.SKIN_PREVIEW_URL}?site_skin=#{@skin.id}"
143144
end
144145

0 commit comments

Comments
 (0)