AO3-7345 Update success message for setting a site skin for a session#5756
Open
jmalark wants to merge 1 commit intootwcode:masterfrom
Open
AO3-7345 Update success message for setting a site skin for a session#5756jmalark wants to merge 1 commit intootwcode:masterfrom
jmalark wants to merge 1 commit intootwcode:masterfrom
Conversation
jmalark
commented
Apr 24, 2026
jmalark
force-pushed
the
AO3-7345-success-message-update-for-site-skin-session
branch
2 times, most recently
from
d4392b3 to
8eaee2d
Compare
slavalamp
suggested changes
Apr 27, 2026
Contributor
slavalamp
left a comment
slavalamp
left a comment
There was a problem hiding this comment.
hi, friendly review from a fellow contributor!
github-actions
Bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
jmalark
force-pushed
the
AO3-7345-success-message-update-for-site-skin-session
branch
8 times, most recently
from
3325748 to
88b7442
Compare
… site skin for a session
jmalark
force-pushed
the
AO3-7345-success-message-update-for-site-skin-session
branch
from
88b7442 to
02d97a5
Compare
Contributor
|
this looks good to me now, thank you 👍🏻 (no idea what's up with the failing test but looks unrelated) |
sarken
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7345
Purpose
Context: When you successfully set a site skin for a session
The success message has been expanded to add a link to the skin page and clarify how long the skin will stay/that it will survive closing the browser.
Credit
Jesse Malark he/him