AO3-5696 Disable orphan account user subscription emails

[pmonfort]

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-5696

Purpose

When orphan_account is a co-creator on a multi-chapter work and another co-creator posts a new chapter without listing orphan_account, users subscribed to orphan_account incorrectly receive subscription emails.

The existing check in Subscription#valid_notification_entry? only inspects the creation's (chapter's) pseuds, missing the case where orphan_account is a co-creator at the work level but not on the individual chapter.

Added a guard that skips notifications when the subscription is to orphan_account directly. Subscribers of other co-creators on the same work are not affected.

Testing Instructions

1. Subscribe to orphan_account
2. Create a work with orphan_account as co-creator
3. Post a new chapter without adding orphan_account as chapter co-creator
4. Run bundle exec rake notifications:deliver_subscriptions
5. Verify no subscription email is sent to the subscriber of orphan_account
6. Verify that subscribers of the other co-creator still receive emails

References

Related to AO3-3620 (Allow subscriptions to orphan_account to receive notifications). When AO3-3620 is fixed, the two
User.orphan_account guards in valid_notification_entry? should be removed.

Credit

Pablo Monfort (he/him)

[redsummernight]

In Oct 2025, we changed the goal of AO3-3620: users will not be able to subscribe to orphan_account. You can remove the TODO comment for AO3-3620 & AO3-5696 completely.

[pmonfort]

@redsummernight Thanks for the review! I've made the updates, let me know if it looks good.

[redsummernight]

Looks good, thank you!