AO3-7393 AO3-7395 Fix blank/invalid pseud editing behavior#5765
Open
techlingyi wants to merge 2 commits intootwcode:masterfrom
Open
AO3-7393 AO3-7395 Fix blank/invalid pseud editing behavior#5765techlingyi wants to merge 2 commits intootwcode:masterfrom
techlingyi wants to merge 2 commits intootwcode:masterfrom
Conversation
Contributor
Author
|
Wow, I haven't seen that Rubocop error before! (A fluke, maybe? If anyone could rerun it that would be nice — it only flagged one error when I ran it the first time, on an identical branch I closed because the commit history was getting confusing.) Edit: Thank you! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7393 - Trying to change a pseud's name to an invalid one makes it so you can't update the pseud again
https://otwarchive.atlassian.net/browse/AO3-7395 - Trying to change a pseud name to an empty one results in error 500
Purpose
Reloads the pseud's original ID if the new pseud is invalid in some way, so that the Show and Update buttons on the edit pseud form are no longer broken upon entering an invalid pseud. This also fixes the 500 error that appears with a blank pseud. An instance variable is used to keep the user's attempted pseud name in the text box (because it would revert back to the original otherwise).
Credit
Ling-Yi (any pronouns)