Skip to content

AO3-7393 AO3-7395 Fix blank/invalid pseud editing behavior#5765

Open
techlingyi wants to merge 2 commits intootwcode:masterfrom
techlingyi:AO3-7393-7395-pseud-editing
Open

AO3-7393 AO3-7395 Fix blank/invalid pseud editing behavior#5765
techlingyi wants to merge 2 commits intootwcode:masterfrom
techlingyi:AO3-7393-7395-pseud-editing

Conversation

@techlingyi
Copy link
Copy Markdown
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7393 - Trying to change a pseud's name to an invalid one makes it so you can't update the pseud again

https://otwarchive.atlassian.net/browse/AO3-7395 - Trying to change a pseud name to an empty one results in error 500

Purpose

Reloads the pseud's original ID if the new pseud is invalid in some way, so that the Show and Update buttons on the edit pseud form are no longer broken upon entering an invalid pseud. This also fixes the 500 error that appears with a blank pseud. An instance variable is used to keep the user's attempted pseud name in the text box (because it would revert back to the original otherwise).

Credit

Ling-Yi (any pronouns)

@techlingyi
Copy link
Copy Markdown
Contributor Author

techlingyi commented Apr 28, 2026

Wow, I haven't seen that Rubocop error before! (A fluke, maybe? If anyone could rerun it that would be nice — it only flagged one error when I ran it the first time, on an identical branch I closed because the commit history was getting confusing.)

Edit: Thank you! :D

@techlingyi techlingyi marked this pull request as ready for review April 28, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant