AO3-7189 Allow admins to change user skin via the Preferences page#5771
Open
Bilka2 wants to merge 1 commit intootwcode:masterfrom
Open
AO3-7189 Allow admins to change user skin via the Preferences page#5771Bilka2 wants to merge 1 commit intootwcode:masterfrom
Bilka2 wants to merge 1 commit intootwcode:masterfrom
Conversation
| @available_locales = Locale.where(email_enabled: true) | ||
|
|
||
| @user.preference.attributes = preference_params | ||
| @user.preference.attributes = permitted_attributes(@preference) |
Member
There was a problem hiding this comment.
With this change, we're moving the parameter list for regular users into a Pundit policy class. We do this in one other place in the code base, PseudPolicy.
I'm surprised this isn't more common, but it makes sense because so far we either deal with objects that are only editable by admins (like admin settings) or have separate controllers to edit user data (users, user creations).
Contributor
Author
There was a problem hiding this comment.
Yes, it's based on https://github.com/varvet/pundit/tree/v2.3.1#strong-parameters. In the current version of pundit the method names have slightly changed but the general idea of having the parameters in the policy is the same
redsummernight
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7189
Purpose
Allow support and superadmins to edit a user's skin via their preferences.
Credit
Bilka