AO3-7399 Add username to Challenge Assignments page title#5778
AO3-7399 Add username to Challenge Assignments page title#5778sagittaerys wants to merge 4 commits intootwcode:masterfrom
Conversation
|
Hi, Olamilekan Aremu! Thank you so much for this pull request. Someone will be along to review it soon. In the meantime, someone updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
|
Can I take on other tasks? |
|
@sagittaerys Yup, you're absolutely welcome to take on additional issues! |
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7399
Purpose
Adds the username to the Challenge Assignments page title to be
consistent with other user pages such as Works and Challenge Claims.
Root cause:
The
indexaction inChallengeAssignmentsControllerwas notsetting
@page_subtitlefor the user assignments view, unlikesimilar pages across the app.
Changes made:
@page_subtitleto the user assignments branch of theindexaction inapp/controllers/challenge_assignments_controller.rbconfig/locales/controllers/en.ymlTesting Instructions
/users/{username}/assignmentsAutomated tests:
spec/controllers/challenge_assignments_controller_spec.rbCommand to run:
docker compose run --rm test bundle exec rspec spec/controllers/challenge_assignments_controller_spec.rbCredit
Name: sagittaerys (Olamilekan Aremu)
Pronouns: (he/him)