AO3-7379 Add delimiters to collection blurb stats numbers#5783
Open
bre-nana wants to merge 3 commits intootwcode:masterfrom
Open
AO3-7379 Add delimiters to collection blurb stats numbers#5783bre-nana wants to merge 3 commits intootwcode:masterfrom
bre-nana wants to merge 3 commits intootwcode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7379
Purpose
Add comma-delimiters to numbers in the collection blurbs (subcollections, prompts, works and/or bookmarked items).
Also converted some related text to use the
t()method.Testing Instructions
Testing instructions on ticket.
Please note I was unsure how to test this myself in development (without manually creating thousands of works/prompts etc 😅). I have matched my changes to the use of the
number_with_delimitermethod elsewhere.Credit
bre-nana (she/they/he)