AO3-7143 Adding filter to user collection page#5788
Open
ReverM wants to merge 29 commits intootwcode:masterfrom
Open
AO3-7143 Adding filter to user collection page#5788ReverM wants to merge 29 commits intootwcode:masterfrom
ReverM wants to merge 29 commits intootwcode:masterfrom
Conversation
This reverts commit b3246cd.
Contributor
Author
|
#5487 original PR. Reopened the PR since merging upstream made it quite angry. Apologies for the added complexity. |
Contributor
Author
|
@sarken pinging you since you commented in the previous PR |
Contributor
Author
|
It seems that the spec controller failure is not expected behaviour after this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7143
Purpose
This adds the ability to filter collections on user pages like on the generic collections page.
Credit
Danaël / Rever (they / he)