AO3-7403 Eager load associations that are used on inbox page#5890
AO3-7403 Eager load associations that are used on inbox page#5890sherin wants to merge 7 commits into
Conversation
sarken
changed the title
|
Hi, and thank you for your interest in contributing! If you could take a few minutes to fill out the pull request template even though this is still a draft, we'd appreciate it. For now, I've updated it with what I believe is the right issue number and set that issue's Jira status to In Review so no one else starts to work on it. If I used the wrong issue, please feel free to make any necessary edits and let me know so I can update the right Jira issue. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
Thank you @sarken ! Oops I did not think anybody would look at this draft PR :) Thanks for updating it. I have sent an email with the relevant jira information so I will wait for that before opening up this PR for review. |
| user { create(:user) } | ||
| feedback_comment { create(:comment) } | ||
|
|
||
| trait :with_guest_comment do |
There was a problem hiding this comment.
Rather than modify the factory I think it's more appropriate to modify your context blocks. We don't need to extract to a shared file for something used in one spot.
|
@nateberkopec thanks for reviewing. i've addressed your feedback. |
3 participants
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7403
Purpose
Removes n+1 from the inbox page.
Testing Instructions
How can the Archive's QA team verify that this is working as you intended?
(I am guessing the following as I am new)
I am not sure if n+1s are tracked in the QA env. If not, making sure the behavior has not changed would be good enough. If sentries are raised in QA for n+1s, then this PR should stop those errors for this page.
Credit
Sherin