Skip to content

AO3-7357 i18n SearchHelper#search_header#5892

Open
not-varram wants to merge 4 commits into
otwcode:masterfrom
not-varram:AO3-7357
Open

AO3-7357 i18n SearchHelper#search_header#5892
not-varram wants to merge 4 commits into
otwcode:masterfrom
not-varram:AO3-7357

Conversation

@not-varram

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7357

Purpose

Rewrote SearchHelper#search_header to fix three i18n issues: pluralisation now uses explicit Rails one/other keys per item type, string concatenation isreplaced with full-phrase translation keys so locales can define their own word order, and each item type now has its own key tree instead of a word being inserted into a shared string.

The method signature was updated to use keyword arguments; all call sites in views were updated accordingly.

Testing Instructions

Automated coverage was added in spec/helpers/search_helper_spec.rb.

(Functional QA flow is documented in the Jira ticket.)

Credit

varram (he/him)

@Bilka2 Bilka2 self-requested a review June 18, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant