Skip to content

AO3-7508 Add link to TOS explaining final decisions#5894

Open
irislawly wants to merge 3 commits into
otwcode:masterfrom
irislawly:AO3-7508-add-link-TOS-decisions
Open

AO3-7508 Add link to TOS explaining final decisions#5894
irislawly wants to merge 3 commits into
otwcode:masterfrom
irislawly:AO3-7508-add-link-TOS-decisions

Conversation

@irislawly

Copy link
Copy Markdown

Pull Request Checklist

  • only added a new link, didn't add test for functionality
  • [X ] Have you added the Jira issue number
    as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
  • [ X] Do you have fewer than 5 pull requests already open? If not, please wait
    until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-7508

Purpose

Add link to TOS explaining final decisions: In the Appeals section of the Terms of Service, the final line “PAC's decisions are final.” should be a link to https://archiveofourown.org/tos_faq#appeal_rejections

Credit

Public name: iris
Pronouns: She/Her

@irislawly

Copy link
Copy Markdown
Author

Hi, I've also sent an email to otw-coders@transformativeworks.org to get permissions to assign myself to the Jira task. I will try to assign and set the task to In Progress when I have permission. Thank you!

@irislawly irislawly changed the title Add link to TOS explaining final decisions AO3-7508: Add link to TOS explaining final decisions Jun 19, 2026
@irislawly irislawly changed the title AO3-7508: Add link to TOS explaining final decisions AO3-7508 Add link to TOS explaining final decisions Jun 19, 2026

@Bilka2 Bilka2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, iris!

Thank you so much for this pull request. Could you include the period at the end of the sentence in the link caption, to match the Jira issue? Additionally, the translation team prefer when the locale keys for the link match the caption of the link, so something like decisions_are_final would work better than the current appeal_rejection.

I see you already have a Jira account with permissions 🎉

Thanks again for contributing! If you have any questions, you can contact us at otw-coders@transformativeworks.org.

@irislawly

Copy link
Copy Markdown
Author

Hi, iris!

Thank you so much for this pull request. Could you include the period at the end of the sentence in the link caption, to match the Jira issue? Additionally, the translation team prefer when the locale keys for the link match the caption of the link, so something like decisions_are_final would work better than the current appeal_rejection.

I see you already have a Jira account with permissions 🎉

Thanks again for contributing! If you have any questions, you can contact us at otw-coders@transformativeworks.org.

Hi @Bilka2 Thanks for reviewing! I've added the period to the end and changed the key to decisions_are_final instead. Please let me know if there's more needed to change. Thanks!

@Bilka2 Bilka2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@Bilka2 Bilka2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, taking back my approval - please also update the appeal_rejection_link to decisions_are_final_link to match the new key

@irislawly

Copy link
Copy Markdown
Author

Sorry, taking back my approval - please also update the appeal_rejection_link to decisions_are_final_link to match the new key
@Bilka2
Okay! I've changed that one too. Thanks

@Bilka2 Bilka2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants