AO3-7477 Update challenge-matching.html popup per feedback on AO3-6277#5895
Open
JSLarson wants to merge 1 commit into
Open
AO3-7477 Update challenge-matching.html popup per feedback on AO3-6277#5895JSLarson wants to merge 1 commit into
JSLarson wants to merge 1 commit into
Conversation
Author
|
No clue why this isn’t passing all tests, will take a look in the morning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7477
Purpose
Adds info about having no matches to the challenge matching info popup as per the ticket.
Testing Instructions
Create a gift-matching challenge with >1 signup, close signups, then click on the popup at /challenge_name/potential_matches.
References
https://otwarchive.atlassian.net/browse/AO3-6277?focusedCommentId=381530
Credit
James Larson (he/she)