Skip to content

AO3-7510 added link about bookmark rules to Content Policy#5908

Open
aadya-khanna wants to merge 2 commits into
otwcode:masterfrom
aadya-khanna:AO3-7510
Open

AO3-7510 added link about bookmark rules to Content Policy#5908
aadya-khanna wants to merge 2 commits into
otwcode:masterfrom
aadya-khanna:AO3-7510

Conversation

@aadya-khanna

Copy link
Copy Markdown

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7510

Purpose

What does this PR do?

This PR adds the desired link in the fanworks section of content policy to the phrase "created for fanwork".

Credit

Name: Aadya
Pronouns: she/her

@sarken sarken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Aadya!

Thank you so much for this pull request. It looks pretty good, but there's a test failure that indicates the locale file needs to be normalized by running the following task: bundle exec i18n-tasks normalize -l en. (You can read more about these tasks in the i18n-tasks section of our Internationalization (i18n) Standards wiki page.)

In the meantime, I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."

Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

@aadya-khanna

Copy link
Copy Markdown
Author

Hi, Aadya!

Thank you so much for this pull request. It looks pretty good, but there's a test failure that indicates the locale file needs to be normalized by running the following task: bundle exec i18n-tasks normalize -l en. (You can read more about these tasks in the i18n-tasks section of our Internationalization (i18n) Standards wiki page.)

In the meantime, I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."

Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

Thank you! I have fixed the failures.
Jira name: Aadya Khanna
Jira email: aadyakhanna12@gmail.com

@sarken sarken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Your Jira permissions should be all set the next time you log in, but if you run into any issues, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants