AO3-4412 Adding a test to ensure there are not N+1 issues when loading inbox comments on the homepage#5913
Open
ASalbenblatt wants to merge 2 commits into
Conversation
…g inbox commets on the homepage
github-actions
Bot
added
Scope: Tests Only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-4412
Purpose
There used to be an issue where there were N+1 database queries when loading inbox comments on the homepage. It looks like this was fixed in AO3-4380, though a test was never added. This PR adds a test for that fix so it won't happen again.
Testing Instructions
Testing is all automated.
Note: the line numbers in the Jira issue no longer point to the relevant lines, as they have moved from commits in the intervening years.
Credit
FlyingFalcon they/them