🐛 fix(loadbalancer): autogenerated names should be <32

Author: jfbus

ccm/cloud/loadbalancer.go

@@ -210,7 +210,12 @@ func NewLoadBalancer(svc *corev1.Service, addTags map[string]string) (*LoadBalan
 	case len(lb.Name) == 0:
 		// autogenerated name, multiple instances (add -a/b/c)
 		lb.Name = make([]string, 0, lb.Instances)
-		base := strings.ReplaceAll(string(svc.UID), "-", "") + "-"
+		base := strings.ReplaceAll(string(svc.UID), "-", "")
+		// UIDs are UUIDs, therefore more than 30 chars without '-', but we never know - things might change
+		if len(base) > 30 {
+			base = base[:30]
+		}
+		base += "-"
 		for i := range lb.Instances {
 			lb.Name = append(lb.Name, base+string([]byte{'a' + byte(i)}))
 		}

ccm/cloud/loadbalancer_config_test.go

@@ -65,6 +65,81 @@ func TestNewLoadBalancer(t *testing.T) {
 			Connection:     cloud.Connection{IdleTimeout: 60},
 			IngressAddress: cloud.Hostname,
 		},
+	}, {
+		name: "autogenerated names are truncated to 32 chars (non multi-az)",
+		svc: &corev1.Service{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: "foo",
+				UID:  "5dbb147b-3878-4d10-bf2d-96b2b463b8eb",
+			},
+			Spec: corev1.ServiceSpec{
+				SessionAffinity: corev1.ServiceAffinityNone,
+				Ports:           []corev1.ServicePort{{Protocol: corev1.ProtocolTCP, Port: 42, NodePort: 43}},
+			},
+		},
+		lb: &cloud.LoadBalancer{
+			Name:        []string{"5dbb147b38784d10bf2d96b2b463b8eb"},
+			Instances:   1,
+			ServiceName: "foo",
+			Listeners: []cloud.Listener{{
+				Port:        42,
+				BackendPort: 43,
+			}},
+			ListenerDefaults: cloud.ListenerDefaults{
+				SSLPorts: []string{"*"},
+			},
+			TargetRole: cloud.DefaultLoadBalancerConfiguration.TargetRole,
+			HealthCheck: cloud.HealthCheck{
+				Port:               43,
+				Protocol:           "tcp",
+				Interval:           cloud.DefaultLoadBalancerConfiguration.HealthCheck.Interval,
+				Timeout:            cloud.DefaultLoadBalancerConfiguration.HealthCheck.Timeout,
+				HealthyThreshold:   cloud.DefaultLoadBalancerConfiguration.HealthCheck.HealthyThreshold,
+				UnhealthyThreshold: cloud.DefaultLoadBalancerConfiguration.HealthCheck.UnhealthyThreshold,
+			},
+			AllowFrom:      ipNetSet("0.0.0.0/0"),
+			Connection:     cloud.Connection{IdleTimeout: 60},
+			IngressAddress: cloud.Hostname,
+		},
+	}, {
+		name: "autogenerated names are truncated to 32 chars (multi-az)",
+		svc: &corev1.Service{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: "foo",
+				UID:  "5dbb147b-3878-4d10-bf2d-96b2b463b8eb",
+				Annotations: map[string]string{
+					"service.beta.kubernetes.io/osc-load-balancer-instances": "2",
+				},
+			},
+			Spec: corev1.ServiceSpec{
+				SessionAffinity: corev1.ServiceAffinityNone,
+				Ports:           []corev1.ServicePort{{Protocol: corev1.ProtocolTCP, Port: 42, NodePort: 43}},
+			},
+		},
+		lb: &cloud.LoadBalancer{
+			Name:        []string{"5dbb147b38784d10bf2d96b2b463b8-a", "5dbb147b38784d10bf2d96b2b463b8-b"},
+			Instances:   2,
+			ServiceName: "foo",
+			Listeners: []cloud.Listener{{
+				Port:        42,
+				BackendPort: 43,
+			}},
+			ListenerDefaults: cloud.ListenerDefaults{
+				SSLPorts: []string{"*"},
+			},
+			TargetRole: cloud.DefaultLoadBalancerConfiguration.TargetRole,
+			HealthCheck: cloud.HealthCheck{
+				Port:               43,
+				Protocol:           "tcp",
+				Interval:           cloud.DefaultLoadBalancerConfiguration.HealthCheck.Interval,
+				Timeout:            cloud.DefaultLoadBalancerConfiguration.HealthCheck.Timeout,
+				HealthyThreshold:   cloud.DefaultLoadBalancerConfiguration.HealthCheck.HealthyThreshold,
+				UnhealthyThreshold: cloud.DefaultLoadBalancerConfiguration.HealthCheck.UnhealthyThreshold,
+			},
+			AllowFrom:      ipNetSet("0.0.0.0/0"),
+			Connection:     cloud.Connection{IdleTimeout: 60},
+			IngressAddress: cloud.Hostname,
+		},
 	}, {
 		name: "Annotations are loaded",
 		svc: &corev1.Service{