✨ feat: set ClientToken if not already set by client#1077
Open
jobs62 wants to merge 1 commit into
Open
Conversation
jfbus
reviewed
Apr 2, 2026
| }, nil | ||
| } | ||
|
|
||
| type clientTokenSetter interface { |
Contributor
There was a problem hiding this comment.
I hesitate. on one hand this is stutter, and the interface appears multiple times (=> a shared interface could do the job). on the other hand, adding a new package for this is maybe too much
| if v, ok := any(body).(clientTokenSetter); ok { | ||
| err := v.SetClientToken() | ||
| if err != nil { | ||
| return nil, err |
Contributor
There was a problem hiding this comment.
you should log and continue... why would it be an error if this thing that the user has not asked for and is not required fails ?
| } | ||
|
|
||
| require.NoError(t, data.SetClientToken()) | ||
| require.NotNil(t, data.ClientToken, "ClientToken should be set by mutateBody") |
Contributor
There was a problem hiding this comment.
assert.NotEmpty(t, data.ClientToken) (it could be not nil but empty)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
set idempotency token automaticly to a new UUIDv7 if not already set by the application. this is done to avoid issues of ressources created multiple times when retrying on a brittle connection.
Type of Change
Please check the relevant option(s):
How Has This Been Tested?
Please describe the test strategy:
Checklist