fix: Windows Electron desktop build compatibility#579
Open
prasairaul-del wants to merge 1 commit into
Open
Conversation
- electron/main.cjs: 6 Windows fixes - fs imported as full module (not just existsSync) - isHermesInstalled() uses 'where hermes' on Windows - getTempDir() helper: %TEMP% on Windows, /tmp on macOS/Linux - spawnDetached() uses cmd /c + windowsHide on Windows - installHermesInBackground() uses pip install (not curl|bash) - desktop:open-logs opens %TEMP% (not /tmp) - electron-builder.config.cjs: added executableName, artifactName, portable target - package.json: removed NODE_OPTIONS prefix (breaks Windows cmd) - src/server/swarm-lifecycle.ts: export sendToWorker (fixes broken import) - AGENTS.md: updated Windows setup notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Windows compatibility for the Electron desktop app (5 files changed, +361/-33).
Changes
electron/main.cjs — 6 Windows fixes
electron-builder.config.cjs
package.json
src/server/swarm-lifecycle.ts
AGENTS.md
Verified