Keep the NavBar while pinned#273
Merged
Merged
Conversation
The NavBar already gets hidden while pinned, no need to remove it from the DOM. Keeping it ensures the MainView stays in the same position (and does not move up a bit when pinned) making it a more consistent experience for the user.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
I actually thought of doing this change in my #266 branch but what I realized is if someone wants to have the discord names right in the top left corner of their screen, then it's not really possible because you can't really drag the window partly off-screen then pin it. Before you could tuck the window top left then pin, and the users would shift up to be tucked into the corner. So... maybe this should be an option? It's very edgecase-y but it's a thought. |
Member
|
oh now we can't get a user at the top left anymore once you pin :( 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NavBar already gets hidden while pinned, no need to remove it from the DOM. Keeping it ensures the MainView stays in the same position (and does not move up a bit when pinned) making it a more consistent experience for the user.