Skip to content

Add pool callback #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JonathanBerrew wants to merge 2 commits into
base: v2/master
Choose a base branch
from
+8 −1
Open

Add pool callback #3517

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e122f37
Add pool callback
JonathanBerrew Mar 18, 2026
6dd093c
fix: handle memory pool creation failure in modsecurity_request_body_…
JonathanBerrew Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apache2/msc_reqbody.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ apr_status_t modsecurity_request_body_start(modsec_rec *msr, char **error_msg) {
* via malloc).
*/
apr_pool_create(&msr->msc_reqbody_mp, NULL);

apr_pool_abort_set(apr_pool_abort_get(msr->mp), msr->msc_reqbody_mp);
/* Initialise request body processors, if any. */
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apr_pool_create(&msr->msc_reqbody_mp, NULL); returns an apr_status_t, but the result isn’t checked before calling apr_pool_abort_set(...) (and later using msr->msc_reqbody_mp). If pool creation fails, this will immediately dereference a NULL pool. Capture the return code, and on failure set *error_msg and return an error before using msr->msc_reqbody_mp.

Copilot uses AI. Check for mistakes.

if (msr->msc_reqbody_processor != NULL) {
Expand Down
Loading