tests: add Other tests

Author: owenvoke

src/Api/Other.php

@@ -6,17 +6,17 @@
 
 class Other extends AbstractApi
 {
-    public function base58(string $data): array
+    public function base58(string $data): string
     {
         return $this->get(self::API_PATH, [
             'q' => 'base58',
             'data' => $data,
         ]);
     }
 
-    public function randomNumber(int $height, int $minimum, int $maximum, ?string $seed = null): array
+    public function randomNumber(int $height, int $minimum, int $maximum, ?string $seed = null): int
     {
-        return $this->get(self::API_PATH, [
+        return (int) $this->get(self::API_PATH, [
             'q' => 'randomNumber',
             'height' => $height,
             'min' => $minimum,
@@ -25,13 +25,13 @@ public function randomNumber(int $height, int $minimum, int $maximum, ?string $s
         ]);
     }
 
-    public function checkSignature(string $signature, string $data, string $publicKey): array
+    public function checkSignature(string $signature, string $data, string $publicKey): bool
     {
-        return $this->get(self::API_PATH, [
+        return ((string) $this->get(self::API_PATH, [
             'q' => 'checkSignature',
             'signature' => $signature,
             'data' => $data,
             'public_key' => $publicKey,
-        ]);
+        ])) === 'true';
     }
 }

tests/Api/NodeTest.php

@@ -92,9 +92,9 @@
             'hash' => 'c7d66b357c05d0908623a09afd387dd3',
             'masternodes' => [
                 [
-                    'public_key' => "PZ8Tyr4Nx8MHsRAGMpZmZ6TWY63dXWSCvNFCyZbpNpLVwg4Sk8Pe46dyKrqR4GacBGtaeJ9CAXQTc41jYrW2gy91XUkBgMkkAjqsojSVMJ1iasdbcmFdx7wy",
+                    'public_key' => 'PZ8Tyr4Nx8MHsRAGMpZmZ6TWY63dXWSCvNFCyZbpNpLVwg4Sk8Pe46dyKrqR4GacBGtaeJ9CAXQTc41jYrW2gy91XUkBgMkkAjqsojSVMJ1iasdbcmFdx7wy',
                     'height' => 104148,
-                    'ip' => "35.237.72.244",
+                    'ip' => '35.237.72.244',
                     'last_won' => 137074,
                     'blacklist' => 0,
                     'fails' => 0,
@@ -113,9 +113,9 @@
         'hash' => 'c7d66b357c05d0908623a09afd387dd3',
         'masternodes' => [
             [
-                'public_key' => "PZ8Tyr4Nx8MHsRAGMpZmZ6TWY63dXWSCvNFCyZbpNpLVwg4Sk8Pe46dyKrqR4GacBGtaeJ9CAXQTc41jYrW2gy91XUkBgMkkAjqsojSVMJ1iasdbcmFdx7wy",
+                'public_key' => 'PZ8Tyr4Nx8MHsRAGMpZmZ6TWY63dXWSCvNFCyZbpNpLVwg4Sk8Pe46dyKrqR4GacBGtaeJ9CAXQTc41jYrW2gy91XUkBgMkkAjqsojSVMJ1iasdbcmFdx7wy',
                 'height' => 104148,
-                'ip' => "35.237.72.244",
+                'ip' => '35.237.72.244',
                 'last_won' => 137074,
                 'blacklist' => 0,
                 'fails' => 0,

tests/Api/OtherTest.php

@@ -6,8 +6,66 @@
 
 beforeEach(fn () => $this->apiClass = Other::class);
 
-it('can get a random number');
+it('can get a random number', function () {
+    $api = $this->getApiMock();
 
-it('can get the Base58 encoded version of a string');
+    $api->expects($this->once())
+        ->method('get')
+        ->with('/api.php', [
+            'q' => 'randomNumber',
+            'height' => 100000,
+            'min' => 10,
+            'max' => 20,
+            'seed' => null,
+        ])
+        ->willReturn('20');
 
-it('can check a signature is valid');
+    /** @var Other $api */
+    expect(
+        $api->randomNumber(
+            height: 100000,
+            minimum: 10,
+            maximum: 20
+        )
+    )->toBe(20);
+});
+
+it('can get the Base58 encoded version of a string', function () {
+    $api = $this->getApiMock();
+
+    $api->expects($this->once())
+        ->method('get')
+        ->with('/api.php', [
+            'q' => 'base58',
+            'data' => 'Test',
+        ])
+        ->willReturn('3A836b');
+
+    /** @var Other $api */
+    expect(
+        $api->base58('Test')
+    )->toBe('3A836b');
+});
+
+it('can check a signature is valid', function () {
+    $api = $this->getApiMock();
+
+    $api->expects($this->once())
+        ->method('get')
+        ->with('/api.php', [
+            'q' => 'checkSignature',
+            'signature' => 'AN1rKroKawax5azYrLbasV7VycYAvQXFKrJ69TFYEfmanXwVRrUQTCx5gQ1eVNMgEVzrEz3VzLsfrVVpUYqgB5eT2qsFtaSsw',
+            'data' => '1.00000000-0.00250000-PXGAMER--2-PZ8Tyr4Nx8MHsRAGMpZmZ6TWY63dXWSCyk7aKeBJ6LL44w5JGSFp82Wb1Drqicuznv1qmRVQMvbmF64AeczjMtV72acGLR9RsiQ2JccemNrSPkKi8KDk72t4-1533911370',
+            'public_key' => 'PZ8Tyr4Nx8MHsRAGMpZmZ6TWY63dXWSCyk7aKeBJ6LL44w5JGSFp82Wb1Drqicuznv1qmRVQMvbmF64AeczjMtV72acGLR9RsiQ2JccemNrSPkKi8KDk72t4',
+        ])
+        ->willReturn('true');
+
+    /** @var Other $api */
+    expect(
+        $api->checkSignature(
+            signature: 'AN1rKroKawax5azYrLbasV7VycYAvQXFKrJ69TFYEfmanXwVRrUQTCx5gQ1eVNMgEVzrEz3VzLsfrVVpUYqgB5eT2qsFtaSsw',
+            data: '1.00000000-0.00250000-PXGAMER--2-PZ8Tyr4Nx8MHsRAGMpZmZ6TWY63dXWSCyk7aKeBJ6LL44w5JGSFp82Wb1Drqicuznv1qmRVQMvbmF64AeczjMtV72acGLR9RsiQ2JccemNrSPkKi8KDk72t4-1533911370',
+            publicKey: 'PZ8Tyr4Nx8MHsRAGMpZmZ6TWY63dXWSCyk7aKeBJ6LL44w5JGSFp82Wb1Drqicuznv1qmRVQMvbmF64AeczjMtV72acGLR9RsiQ2JccemNrSPkKi8KDk72t4',
+        )
+    )->toBe(true);
+});