Skip to content

Commit 148d5cf

Browse files
authored
Merge pull request #4834 from owncloud/fix/support_expiration_dates_without_milliseconds
[FIX] Crash when space link has an specific expiration date format
2 parents aa4887b + fff51d6 commit 148d5cf

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

changelog/unreleased/4783

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@ This new section shows information like public link names, types and expiration
55

66
https://github.com/owncloud/android/issues/4752
77
https://github.com/owncloud/android/pull/4783
8+
https://github.com/owncloud/android/pull/4834

owncloudApp/src/main/java/com/owncloud/android/utils/DisplayUtils.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ public class DisplayUtils {
6262
private static final int[] sizeScales = {0, 0, 1, 1, 1, 2, 2, 2, 2};
6363

6464
private static final String DATE_FORMAT_DISPLAY = "dd/MM/yyyy HH:mm";
65+
private static final String DATE_FORMAT_ISO_WITHOUT_MILLISECONDS = "yyyy-MM-dd'T'HH:mm:ss'Z'";
6566
public static final String DATE_FORMAT_ISO = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'";
6667

6768
private static Map<String, String> mimeType2HumanReadable;
@@ -290,8 +291,12 @@ public static Pair<String, String> formatFromBytes(long bytes) {
290291
public static String displayDateToHumanReadable(String date) throws ParseException {
291292
SimpleDateFormat parser = new SimpleDateFormat(DATE_FORMAT_ISO, Locale.ROOT);
292293
parser.setTimeZone(TimeZone.getTimeZone("UTC"));
293-
Date dateParsed = parser.parse(date);
294294
SimpleDateFormat formatter = new SimpleDateFormat(DATE_FORMAT_DISPLAY, Locale.ROOT);
295-
return formatter.format(dateParsed);
295+
try {
296+
return formatter.format(parser.parse(date));
297+
} catch (ParseException e) {
298+
parser.applyPattern(DATE_FORMAT_ISO_WITHOUT_MILLISECONDS);
299+
return formatter.format(parser.parse(date));
300+
}
296301
}
297302
}

0 commit comments

Comments
 (0)