Merge pull request #4652 from owncloud/fix/transfer_list_fragment_crash_from_play_console

[FIX] Crash in TransferListFragment (Play Console)

Author: jesmrec

CHANGELOG.md

@@ -37,10 +37,20 @@ ownCloud admins and users.
 
 ## Summary
 
+* Bugfix - Crash from Google Play Console in TransferListFragment: [#4650](https://github.com/owncloud/android/issues/4650)
 * Bugfix - Mini-fab for creating new document not always available: [#7277](https://github.com/owncloud/enterprise/issues/7277)
 
 ## Details
 
+* Bugfix - Crash from Google Play Console in TransferListFragment: [#4650](https://github.com/owncloud/android/issues/4650)
+
+   In order to prevent app crashes, the account parameter from TransferListFragment
+   has been removed and the newInstance method has been created to pass parameters
+   safely.
+
+   https://github.com/owncloud/android/issues/4650
+   https://github.com/owncloud/android/pull/4652
+
 * Bugfix - Mini-fab for creating new document not always available: [#7277](https://github.com/owncloud/enterprise/issues/7277)
 
    The productName property has been made nullable to handle cases where it is not

changelog/unreleased/4652

@@ -0,0 +1,7 @@
+Bugfix: Crash from Google Play Console in TransferListFragment
+
+In order to prevent app crashes, the account parameter from TransferListFragment has
+been removed and the newInstance method has been created to pass parameters safely.
+
+https://github.com/owncloud/android/issues/4650
+https://github.com/owncloud/android/pull/4652

owncloudApp/src/main/java/com/owncloud/android/presentation/transfers/TransferListFragment.kt

@@ -47,14 +47,12 @@ import org.koin.androidx.viewmodel.ext.android.viewModel
 import org.koin.core.parameter.parametersOf
 import java.io.File
 
-class TransferListFragment(
-    private val account: Account
-) : Fragment() {
+class TransferListFragment : Fragment() {
 
     private val transfersViewModel by viewModel<TransfersViewModel>()
     private val capabilityViewModel: CapabilityViewModel by viewModel {
         parametersOf(
-            account.name,
+            requireArguments().getString(ARG_ACCOUNT_NAME),
         )
     }
 
@@ -141,4 +139,16 @@ class TransferListFragment(
         }
         transfersAdapter.setData(transfersWithSpace)
     }
+
+    companion object {
+        private const val ARG_ACCOUNT_NAME = "ACCOUNT_NAME"
+
+        @JvmStatic
+        fun newInstance(account: Account): TransferListFragment {
+            val args = Bundle().apply {
+                putString(ARG_ACCOUNT_NAME, account.name)
+            }
+            return TransferListFragment().apply { arguments = args }
+        }
+    }
 }

owncloudApp/src/main/java/com/owncloud/android/ui/activity/UploadListActivity.java

@@ -94,7 +94,7 @@ protected void onCreate(Bundle savedInstanceState) {
 
     private void createUploadListFragment() {
         //UploadListFragment uploadList = new UploadListFragment();
-        TransferListFragment uploadList = new TransferListFragment(getAccount());
+        TransferListFragment uploadList = TransferListFragment.newInstance(getAccount());
         FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();
         transaction.add(R.id.left_fragment_container, uploadList, TAG_UPLOAD_LIST_FRAGMENT);
         transaction.commit();