Skip to content

Commit 57af32a

Browse files
authored
Merge pull request #3985 from owncloud/remove_drives_permission_parsing
Remove permission parsing from spaces.
2 parents d7b2c51 + 3b12ed9 commit 57af32a

5 files changed

Lines changed: 1 addition & 43 deletions

File tree

owncloudData/src/main/java/com/owncloud/android/data/spaces/datasources/implementation/OCLocalSpacesDataSource.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ class OCLocalSpacesDataSource(
164164
SpaceRoot(
165165
eTag = spaceRootEntity.eTag,
166166
id = spaceRootEntity.id,
167-
permissions = null,
168167
webDavUrl = spaceRootEntity.webDavUrl,
169168
deleted = spaceRootEntity.deleteState?.let { SpaceDeleted(state = it) },
170169
)

owncloudData/src/main/java/com/owncloud/android/data/spaces/datasources/implementation/OCRemoteSpacesDataSource.kt

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,12 @@ import com.owncloud.android.data.spaces.datasources.RemoteSpacesDataSource
2424
import com.owncloud.android.domain.spaces.model.OCSpace
2525
import com.owncloud.android.domain.spaces.model.SpaceDeleted
2626
import com.owncloud.android.domain.spaces.model.SpaceFile
27-
import com.owncloud.android.domain.spaces.model.SpaceGrantedToIdentities
2827
import com.owncloud.android.domain.spaces.model.SpaceOwner
29-
import com.owncloud.android.domain.spaces.model.SpacePermission
30-
import com.owncloud.android.domain.spaces.model.SpacePermissionIdentity
3128
import com.owncloud.android.domain.spaces.model.SpaceQuota
3229
import com.owncloud.android.domain.spaces.model.SpaceRoot
3330
import com.owncloud.android.domain.spaces.model.SpaceSpecial
3431
import com.owncloud.android.domain.spaces.model.SpaceSpecialFolder
3532
import com.owncloud.android.domain.spaces.model.SpaceUser
36-
import com.owncloud.android.lib.resources.spaces.responses.IdentityPermissionResponse
3733
import com.owncloud.android.lib.resources.spaces.responses.SpaceResponse
3834

3935
class OCRemoteSpacesDataSource(
@@ -73,17 +69,6 @@ class OCRemoteSpacesDataSource(
7369
root = SpaceRoot(
7470
eTag = root.eTag,
7571
id = root.id,
76-
permissions = root.permissions?.map { permissionsResponse ->
77-
SpacePermission(
78-
grantedToIdentities = permissionsResponse.getGrantedToIdentitiesResponse().map { grantedToResponse ->
79-
SpaceGrantedToIdentities(
80-
user = grantedToResponse.user?.toModel(),
81-
group = grantedToResponse.group?.toModel(),
82-
)
83-
},
84-
roles = permissionsResponse.roles,
85-
)
86-
},
8772
webDavUrl = root.webDavUrl,
8873
deleted = root.deleted?.let { SpaceDeleted(state = it.state) }
8974
),
@@ -102,11 +87,4 @@ class OCRemoteSpacesDataSource(
10287
)
10388
}
10489
)
105-
106-
private fun IdentityPermissionResponse.toModel() =
107-
SpacePermissionIdentity(
108-
id = this.id,
109-
displayName = this.displayName,
110-
)
111-
11290
}

owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/model/OCSpace.kt

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ data class SpaceQuota(
7171
data class SpaceRoot(
7272
val eTag: String?,
7373
val id: String,
74-
val permissions: List<SpacePermission>?,
7574
val webDavUrl: String,
7675
val deleted: SpaceDeleted?,
7776
)
@@ -99,21 +98,6 @@ data class SpaceFile(
9998
val mimeType: String
10099
)
101100

102-
data class SpacePermission(
103-
val grantedToIdentities: List<SpaceGrantedToIdentities>,
104-
val roles: List<String>
105-
)
106-
107-
data class SpaceGrantedToIdentities(
108-
val user: SpacePermissionIdentity?,
109-
val group: SpacePermissionIdentity?,
110-
)
111-
112-
data class SpacePermissionIdentity(
113-
val id: String,
114-
val displayName: String?,
115-
)
116-
117101
data class SpaceSpecialFolder(
118102
val name: String
119103
)

owncloudTestUtil/src/main/java/com/owncloud/android/testutil/OCSpace.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ val OC_SPACE_PROJECT_WITH_IMAGE = OCSpace(
8181
root = SpaceRoot(
8282
eTag = "989c7968dbbbde8c5fd9849b9123c384",
8383
id = "8871f4f3-fc6f-4a66-8bed-62f175f76f38$0aa0e03c-ec36-498c-bb9f-857315568199",
84-
permissions = null,
8584
webDavUrl = "https://server.com/dav/spaces/8871f4f3-fc6f-4a66-8bed-62f175f76f38$0aa0e03c-ec36-498c-bb9f-857315568199",
8685
deleted = null
8786
),
@@ -99,7 +98,6 @@ val OC_SPACE_PROJECT_WITHOUT_IMAGE = OC_SPACE_PROJECT_WITH_IMAGE.copy(
9998
root = SpaceRoot(
10099
eTag = "989c7968dbbbde8c5fd9849b9123c384",
101100
id = "8871f4f3-fc6f-4a66-8bed-62f175f76f38$0aa0e03c-ec36-498c-bb9f-1234566789",
102-
permissions = null,
103101
webDavUrl = "https://server.com/dav/spaces/8871f4f3-fc6f-4a66-8bed-62f175f76f38$0aa0e03c-ec36-498c-bb9f-1234566789",
104102
deleted = null
105103
),
@@ -125,7 +123,6 @@ val OC_SPACE_PROJECT_DISABLED = OC_SPACE_PROJECT_WITH_IMAGE.copy(
125123
root = SpaceRoot(
126124
eTag = "989c7968dbbbde8c5fd9849b9123c384",
127125
id = "8871f4f3-fc6f-4a66-8bed-62f175f76f38$0aa0e03c-ec36-498c-bb9f-857315568199",
128-
permissions = null,
129126
webDavUrl = "https://server.com/dav/spaces/8871f4f3-fc6f-4a66-8bed-62f175f76f38$0aa0e03c-ec36-498c-bb9f-857315568199",
130127
deleted = SpaceDeleted(
131128
state = "trashed"

0 commit comments

Comments
 (0)