Skip to content

Commit 758ed0b

Browse files
committed
fix: keep simple UX
1 parent 607e750 commit 758ed0b

File tree

2 files changed

+1
-22
lines changed

2 files changed

+1
-22
lines changed

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
7373
private var canRemoveMembers = false
7474
private var canEditMembers = false
7575
private var canReadMembers = false
76-
private var spacePermissionsLoaded = false
7776
private var numberOfManagers = 1
7877

7978
override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
@@ -236,7 +235,6 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
236235
when (val uiResult = event.peekContent()) {
237236
is UIResult.Success -> {
238237
uiResult.data?.let { spacePermissions ->
239-
spacePermissionsLoaded = true
240238
binding.addMemberButton.isVisible = DRIVES_CREATE_PERMISSION in spacePermissions
241239
canRemoveMembers = DRIVES_DELETE_PERMISSION in spacePermissions
242240
canEditMembers = DRIVES_UPDATE_PERMISSION in spacePermissions
@@ -310,18 +308,7 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
310308
}
311309

312310
private fun updateMembersLoadingProgressVisibility(isLoading: Boolean) {
313-
if (!isLoading) {
314-
binding.indeterminateProgressBar.isVisible = false
315-
binding.noReadMembersLoadingProgress.isVisible = false
316-
return
317-
}
318-
if (canReadMembers) {
319-
binding.indeterminateProgressBar.isVisible = true
320-
binding.noReadMembersLoadingProgress.isVisible = false
321-
} else {
322-
binding.indeterminateProgressBar.isVisible = false
323-
binding.noReadMembersLoadingProgress.isVisible = true
324-
}
311+
binding.indeterminateProgressBar.isVisible = isLoading
325312
}
326313

327314
private fun showSpaceLinks(spaceLinks: List<OCLink>) {

owncloudApp/src/main/res/layout/members_fragment.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -93,14 +93,6 @@
9393

9494
</LinearLayout>
9595

96-
<ProgressBar
97-
android:id="@+id/no_read_members_loading_progress"
98-
android:layout_width="wrap_content"
99-
android:layout_height="wrap_content"
100-
android:layout_gravity="center"
101-
android:indeterminate="true"
102-
android:visibility="gone"/>
103-
10496
<LinearLayout
10597
android:id="@+id/public_links_section"
10698
android:layout_width="match_parent"

0 commit comments

Comments
 (0)