feat: implement methods and network operation to edit the password link

joragua · joragua · commit 7bf6ff0c000b · 2026-04-22T09:30:31.000+02:00
diff --git a/owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/UseCaseModule.kt b/owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/UseCaseModule.kt
@@ -81,6 +81,7 @@ import com.owncloud.android.domain.files.usecases.SortFilesWithSyncInfoUseCase
 import com.owncloud.android.domain.files.usecases.UpdateAlreadyDownloadedFilesPathUseCase
 import com.owncloud.android.domain.links.usecases.AddLinkUseCase
 import com.owncloud.android.domain.links.usecases.EditLinkUseCase
+import com.owncloud.android.domain.links.usecases.EditPasswordLinkUseCase
 import com.owncloud.android.domain.links.usecases.RemoveLinkUseCase
 import com.owncloud.android.domain.members.usecases.AddMemberUseCase
 import com.owncloud.android.domain.members.usecases.EditMemberUseCase
@@ -323,5 +324,6 @@ val useCaseModule = module {
     // Links
     factoryOf(::AddLinkUseCase)
     factoryOf(::EditLinkUseCase)
+    factoryOf(::EditPasswordLinkUseCase)
     factoryOf(::RemoveLinkUseCase)
 }
diff --git a/owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/links/AddPublicLinkFragment.kt b/owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/links/AddPublicLinkFragment.kt
@@ -287,7 +287,7 @@ class AddPublicLinkFragment: Fragment(), SetPasswordDialogFragment.SetPasswordLi
             }
 
             if (it.hasPassword) {
-                spaceLinksViewModel.onPasswordSelected(null, true)
+                spaceLinksViewModel.onPasswordSelected(password = null, hasPassword = true, wasPasswordChanged = false)
             }
 
             it.expirationDateTime?.let { expirationDate ->
diff --git a/owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/links/SpaceLinksViewModel.kt b/owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/links/SpaceLinksViewModel.kt
@@ -28,6 +28,7 @@ import com.owncloud.android.domain.capabilities.usecases.GetStoredCapabilitiesUs
 import com.owncloud.android.domain.links.model.OCLinkType
 import com.owncloud.android.domain.links.usecases.AddLinkUseCase
 import com.owncloud.android.domain.links.usecases.EditLinkUseCase
+import com.owncloud.android.domain.links.usecases.EditPasswordLinkUseCase
 import com.owncloud.android.domain.links.usecases.RemoveLinkUseCase
 import com.owncloud.android.domain.spaces.model.OCSpace
 import com.owncloud.android.domain.utils.Event
@@ -44,6 +45,7 @@ import kotlinx.coroutines.launch
 class SpaceLinksViewModel(
     private val addLinkUseCase: AddLinkUseCase,
     private val editLinkUseCase: EditLinkUseCase,
+    private val editPasswordLinkUseCase: EditPasswordLinkUseCase,
     private val getStoredCapabilitiesUseCase: GetStoredCapabilitiesUseCase,
     private val removeLinkUseCase: RemoveLinkUseCase,
     private val accountName: String,
@@ -80,8 +82,8 @@ class SpaceLinksViewModel(
         _addPublicLinkUIState.update { it?.copy(selectedExpirationDate = expirationDate) }
     }
 
-    fun onPasswordSelected(password: String?, hasPassword: Boolean) {
-        _addPublicLinkUIState.update { it?.copy(selectedPassword = password, hasPassword = hasPassword) }
+    fun onPasswordSelected(password: String?, hasPassword: Boolean, wasPasswordChanged: Boolean = true) {
+        _addPublicLinkUIState.update { it?.copy(selectedPassword = password, hasPassword = hasPassword, wasPasswordChanged = wasPasswordChanged) }
     }
 
     fun createPublicLink(displayName: String) {
@@ -130,6 +132,16 @@ class SpaceLinksViewModel(
                     expirationDate = _addPublicLinkUIState.value?.selectedExpirationDate,
                 )
             )
+            if (_addPublicLinkUIState.value?.wasPasswordChanged == true) {
+                viewModelScope.launch(coroutineDispatcherProvider.io) {
+                    editPasswordLinkUseCase(EditPasswordLinkUseCase.Params(
+                        accountName = accountName,
+                        spaceId = space.id,
+                        linkId = linkId,
+                        password = _addPublicLinkUIState.value?.selectedPassword
+                    ))
+                }
+            }
         }
     }
 
@@ -151,6 +163,7 @@ class SpaceLinksViewModel(
         val selectedPermission: OCLinkType? = null,
         val selectedExpirationDate: String? = null,
         val selectedPassword: String? = null,
-        val hasPassword: Boolean = false
+        val hasPassword: Boolean = false,
+        val wasPasswordChanged: Boolean = false
     )
 }
diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/links/EditRemotePasswordLinkOperation.kt b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/links/EditRemotePasswordLinkOperation.kt
@@ -0,0 +1,83 @@
+/**
+ * ownCloud Android client application
+ *
+ * @author Jorge Aguado Recio
+ *
+ * Copyright (C) 2026 ownCloud GmbH.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package com.owncloud.android.lib.resources.links
+
+import com.owncloud.android.lib.common.OwnCloudClient
+import com.owncloud.android.lib.common.http.HttpConstants
+import com.owncloud.android.lib.common.http.HttpConstants.CONTENT_TYPE_JSON
+import com.owncloud.android.lib.common.http.methods.nonwebdav.PostMethod
+import com.owncloud.android.lib.common.operations.RemoteOperation
+import com.owncloud.android.lib.common.operations.RemoteOperationResult
+import com.owncloud.android.lib.common.operations.RemoteOperationResult.ResultCode
+import okhttp3.MediaType.Companion.toMediaType
+import okhttp3.RequestBody.Companion.toRequestBody
+import org.json.JSONObject
+import timber.log.Timber
+import java.net.URL
+
+class EditRemotePasswordLinkOperation(
+    private val spaceId: String,
+    private val linkId: String,
+    private val password: String?
+): RemoteOperation<Unit>() {
+    override fun run(client: OwnCloudClient): RemoteOperationResult<Unit> {
+        var result: RemoteOperationResult<Unit>
+        try {
+            val uriBuilder = client.baseUri.buildUpon().apply {
+                appendEncodedPath(GRAPH_API_DRIVES_PATH)
+                appendEncodedPath(spaceId)
+                appendEncodedPath(GRAPH_API_ROOT_PERMISSIONS_PATH)
+                appendEncodedPath(linkId)
+                appendEncodedPath(GRAPH_API_SET_PASSWORD_PATH)
+            }
+
+            val requestBody = JSONObject().apply {
+                put(PASSWORD_BODY_PARAM, password)
+            }.toString().toRequestBody(CONTENT_TYPE_JSON.toMediaType())
+
+            val postMethod = PostMethod(URL(uriBuilder.build().toString()), requestBody)
+
+            val status = client.executeHttpMethod(postMethod)
+
+            val response = postMethod.getResponseBodyAsString()
+
+            if (status == HttpConstants.HTTP_OK) {
+                Timber.d("Successful response: $response")
+                result = RemoteOperationResult(ResultCode.OK)
+                Timber.d("Edit password public link operation completed and parsed to ${result.data}")
+            } else {
+                result = RemoteOperationResult(postMethod)
+                Timber.e("Failed response while editing password public link; status code: $status, response: $response")
+            }
+        } catch (e: Exception) {
+            result = RemoteOperationResult(e)
+            Timber.e(e, "Exception while editing password public link")
+        }
+        return result
+    }
+
+    companion object {
+        private const val GRAPH_API_DRIVES_PATH = "graph/v1beta1/drives/"
+        private const val GRAPH_API_ROOT_PERMISSIONS_PATH = "root/permissions"
+        private const val GRAPH_API_SET_PASSWORD_PATH = "setPassword"
+        private const val PASSWORD_BODY_PARAM = "password"
+    }
+}
diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/links/services/LinksService.kt b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/links/services/LinksService.kt
@@ -26,5 +26,6 @@ import com.owncloud.android.lib.resources.Service
 interface LinksService: Service {
     fun addLink(spaceId: String, displayName: String, type: String, expirationDate: String?, password: String?): RemoteOperationResult<Unit>
     fun editLink(spaceId: String, linkId: String, displayName: String, type: String, expirationDate: String?): RemoteOperationResult<Unit>
+    fun editPasswordLink(spaceId: String, linkId: String, password: String?): RemoteOperationResult<Unit>
     fun removeLink(spaceId: String, linkId: String): RemoteOperationResult<Unit>
 }
diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/links/services/OCLinksService.kt b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/links/services/OCLinksService.kt
@@ -24,6 +24,7 @@ import com.owncloud.android.lib.common.OwnCloudClient
 import com.owncloud.android.lib.common.operations.RemoteOperationResult
 import com.owncloud.android.lib.resources.links.AddRemoteLinkOperation
 import com.owncloud.android.lib.resources.links.EditRemoteLinkOperation
+import com.owncloud.android.lib.resources.links.EditRemotePasswordLinkOperation
 import com.owncloud.android.lib.resources.links.RemoveRemoteLinkOperation
 
 class OCLinksService(override val client: OwnCloudClient) : LinksService {
@@ -58,6 +59,13 @@ class OCLinksService(override val client: OwnCloudClient) : LinksService {
             expirationDate = expirationDate
         ).execute(client)
 
+    override fun editPasswordLink(spaceId: String, linkId: String, password: String?): RemoteOperationResult<Unit> =
+        EditRemotePasswordLinkOperation(
+            spaceId = spaceId,
+            linkId = linkId,
+            password = password
+        ).execute(client)
+
     override fun removeLink(spaceId: String, linkId: String): RemoteOperationResult<Unit> =
         RemoveRemoteLinkOperation(
             spaceId = spaceId,
diff --git a/owncloudData/src/main/java/com/owncloud/android/data/links/datasources/RemoteLinksDataSource.kt b/owncloudData/src/main/java/com/owncloud/android/data/links/datasources/RemoteLinksDataSource.kt
@@ -25,5 +25,6 @@ import com.owncloud.android.domain.links.model.OCLinkType
 interface RemoteLinksDataSource {
     fun addLink(accountName: String, spaceId: String, displayName: String, type: OCLinkType, expirationDate: String?, password: String?)
     fun editLink(accountName: String, spaceId: String, linkId: String, displayName: String, type: OCLinkType, expirationDate: String?)
+    fun editPasswordLink(accountName: String, spaceId: String, linkId: String, password: String?)
     fun removeLink(accountName: String, spaceId: String, linkId: String)
 }
diff --git a/owncloudData/src/main/java/com/owncloud/android/data/links/datasources/implementation/OCRemoteLinksDataSource.kt b/owncloudData/src/main/java/com/owncloud/android/data/links/datasources/implementation/OCRemoteLinksDataSource.kt
@@ -41,6 +41,12 @@ class OCRemoteLinksDataSource(
         }
     }
 
+    override fun editPasswordLink(accountName: String, spaceId: String, linkId: String, password: String?) {
+        executeRemoteOperation {
+            clientManager.getLinksService(accountName).editPasswordLink(spaceId, linkId, password)
+        }
+    }
+
     override fun removeLink(accountName: String, spaceId: String, linkId: String) {
         executeRemoteOperation {
             clientManager.getLinksService(accountName).removeLink(spaceId, linkId)
diff --git a/owncloudData/src/main/java/com/owncloud/android/data/links/repository/OCLinksRepository.kt b/owncloudData/src/main/java/com/owncloud/android/data/links/repository/OCLinksRepository.kt
@@ -36,6 +36,10 @@ class OCLinksRepository(
         remoteLinksDataSource.editLink(accountName, spaceId, linkId, displayName, type, expirationDate)
     }
 
+    override fun editPasswordLink(accountName: String, spaceId: String, linkId: String, password: String?) {
+        remoteLinksDataSource.editPasswordLink(accountName, spaceId, linkId, password)
+    }
+
     override fun removeLink(accountName: String, spaceId: String, linkId: String) {
         remoteLinksDataSource.removeLink(accountName, spaceId, linkId)
     }
diff --git a/owncloudDomain/src/main/java/com/owncloud/android/domain/links/LinksRepository.kt b/owncloudDomain/src/main/java/com/owncloud/android/domain/links/LinksRepository.kt
@@ -25,5 +25,6 @@ import com.owncloud.android.domain.links.model.OCLinkType
 interface LinksRepository {
     fun addLink(accountName: String, spaceId: String, displayName: String, type: OCLinkType, expirationDate: String?, password: String?)
     fun editLink(accountName: String, spaceId: String, linkId: String, displayName: String, type: OCLinkType, expirationDate: String?)
+    fun editPasswordLink(accountName: String, spaceId: String, linkId: String, password: String?)
     fun removeLink(accountName: String, spaceId: String, linkId: String)
 }
diff --git a/owncloudDomain/src/main/java/com/owncloud/android/domain/links/usecases/EditPasswordLinkUseCase.kt b/owncloudDomain/src/main/java/com/owncloud/android/domain/links/usecases/EditPasswordLinkUseCase.kt
@@ -0,0 +1,40 @@
+/**
+ * ownCloud Android client application
+ *
+ * @author Jorge Aguado Recio
+ *
+ * Copyright (C) 2026 ownCloud GmbH.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package com.owncloud.android.domain.links.usecases
+
+import com.owncloud.android.domain.BaseUseCaseWithResult
+import com.owncloud.android.domain.links.LinksRepository
+
+class EditPasswordLinkUseCase(
+    private val linksRepository: LinksRepository
+): BaseUseCaseWithResult<Unit, EditPasswordLinkUseCase.Params>() {
+
+    override fun run(params: Params) {
+        linksRepository.editPasswordLink(params.accountName, params.spaceId, params.linkId, params.password)
+    }
+
+    data class Params(
+        val accountName: String,
+        val spaceId: String,
+        val linkId: String,
+        val password: String?
+    )
+}

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ class AddPublicLinkFragment: Fragment(), SetPasswordDialogFragment.SetPasswordLi`
`287`	`287`	`}`
`288`	`288`
`289`	`289`	`if (it.hasPassword) {`
`290`		`- spaceLinksViewModel.onPasswordSelected(null, true)`
	`290`	`+ spaceLinksViewModel.onPasswordSelected(password = null, hasPassword = true, wasPasswordChanged = false)`
`291`	`291`	`}`
`292`	`292`
`293`	`293`	`it.expirationDateTime?.let { expirationDate ->`
Original file line number	Diff line number	Diff line change
`@@ -26,5 +26,6 @@ import com.owncloud.android.lib.resources.Service`
`26`	`26`	`interface LinksService: Service {`
`27`	`27`	`fun addLink(spaceId: String, displayName: String, type: String, expirationDate: String?, password: String?): RemoteOperationResult<Unit>`
`28`	`28`	`fun editLink(spaceId: String, linkId: String, displayName: String, type: String, expirationDate: String?): RemoteOperationResult<Unit>`
	`29`	`+ fun editPasswordLink(spaceId: String, linkId: String, password: String?): RemoteOperationResult<Unit>`
`29`	`30`	`fun removeLink(spaceId: String, linkId: String): RemoteOperationResult<Unit>`
`30`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,5 +25,6 @@ import com.owncloud.android.domain.links.model.OCLinkType`
`25`	`25`	`interface RemoteLinksDataSource {`
`26`	`26`	`fun addLink(accountName: String, spaceId: String, displayName: String, type: OCLinkType, expirationDate: String?, password: String?)`
`27`	`27`	`fun editLink(accountName: String, spaceId: String, linkId: String, displayName: String, type: OCLinkType, expirationDate: String?)`
	`28`	`+ fun editPasswordLink(accountName: String, spaceId: String, linkId: String, password: String?)`
`28`	`29`	`fun removeLink(accountName: String, spaceId: String, linkId: String)`
`29`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,12 @@ class OCRemoteLinksDataSource(`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`
	`44`	`+ override fun editPasswordLink(accountName: String, spaceId: String, linkId: String, password: String?) {`
	`45`	`+ executeRemoteOperation {`
	`46`	`+ clientManager.getLinksService(accountName).editPasswordLink(spaceId, linkId, password)`
	`47`	`+ }`
	`48`	`+ }`
	`49`	`+`
`44`	`50`	`override fun removeLink(accountName: String, spaceId: String, linkId: String) {`
`45`	`51`	`executeRemoteOperation {`
`46`	`52`	`clientManager.getLinksService(accountName).removeLink(spaceId, linkId)`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,10 @@ class OCLinksRepository(`
`36`	`36`	`remoteLinksDataSource.editLink(accountName, spaceId, linkId, displayName, type, expirationDate)`
`37`	`37`	`}`
`38`	`38`
	`39`	`+ override fun editPasswordLink(accountName: String, spaceId: String, linkId: String, password: String?) {`
	`40`	`+ remoteLinksDataSource.editPasswordLink(accountName, spaceId, linkId, password)`
	`41`	`+ }`
	`42`	`+`
`39`	`43`	`override fun removeLink(accountName: String, spaceId: String, linkId: String) {`
`40`	`44`	`remoteLinksDataSource.removeLink(accountName, spaceId, linkId)`
`41`	`45`	`}`