fix: Added isNewVersionCode function to the condition

Author: Aitorbp

owncloudApp/src/main/java/com/owncloud/android/MainApp.kt

@@ -136,7 +136,7 @@ class MainApp : Application() {
 
                         val pref = PreferenceManager.getDefaultSharedPreferences(appContext)
                         val clearDataAlreadyTriggered = pref.contains(PREFERENCE_CLEAR_DATA_ALREADY_TRIGGERED)
-                        if (clearDataAlreadyTriggered) {
+                        if (clearDataAlreadyTriggered || isNewVersionCode()) {
                             val dontShowAgainDialogPref = pref.getBoolean(PREFERENCE_KEY_DONT_SHOW_OCIS_ACCOUNT_WARNING_DIALOG, false)
                             if (!dontShowAgainDialogPref && shouldShowDialog(activity)) {
                                 val checkboxDialog = activity.layoutInflater.inflate(R.layout.checkbox_dialog, null)
@@ -389,5 +389,13 @@ class MainApp : Application() {
             val pref = PreferenceManager.getDefaultSharedPreferences(appContext)
             return pref.getInt(PREFERENCE_KEY_LAST_SEEN_VERSION_CODE, 0)
         }
+
+        private fun isNewVersionCode(): Boolean {
+            val lastSeenVersionCode = getLastSeenVersionCode()
+            if (lastSeenVersionCode == 0) { // The preferences have been deleted, so we can delete the accounts and navigate to login
+                return false
+            }
+            return lastSeenVersionCode != versionCode // The version has changed and the accounts must not be deleted
+        }
     }
 }

owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

@@ -188,6 +188,10 @@ class FileDisplayActivity : FileActivity(),
         super.onCreate(savedInstanceState) // this calls onAccountChanged() when ownCloud Account is valid
 
         checkPasscodeEnforced(this)
+
+        if (BuildConfig.DEBUG) {
+            sharedPreferences.putInt(MainApp.PREFERENCE_KEY_LAST_SEEN_VERSION_CODE, MainApp.versionCode)
+        }
         sharedPreferences.putBoolean(PREFERENCE_CLEAR_DATA_ALREADY_TRIGGERED, true)
         localBroadcastManager = LocalBroadcastManager.getInstance(this)