Skip to content

[FEATURE REQUEST] Create new set of configurations for Kiteworks servers in setup.xml#4632

Merged
joragua merged 13 commits into
masterfrom
feature/new_setup_for_kiteworks_servers
Jul 15, 2025
Merged

[FEATURE REQUEST] Create new set of configurations for Kiteworks servers in setup.xml#4632
joragua merged 13 commits into
masterfrom
feature/new_setup_for_kiteworks_servers

Conversation

@joragua
Copy link
Copy Markdown
Contributor

@joragua joragua commented Jul 8, 2025 •
edited
Loading

Related Issues

App: #4622

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Jul 8, 2025
@joragua joragua linked an issue Jul 8, 2025 that may be closed by this pull request
[FEATURE REQUEST] Create new set of configurations for Kiteworks servers in setup.xml #4622
Closed
12 tasks
@joragua joragua force-pushed the feature/new_setup_for_kiteworks_servers branch 4 times, most recently from f66b3fe to 349d5f6 Compare July 14, 2025 06:14
@joragua joragua marked this pull request as ready for review July 14, 2025 07:41
@joragua joragua requested a review from jesmrec July 14, 2025 07:41
jesmrec
jesmrec requested changes Jul 14, 2025
View reviewed changes
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/authentication/LoginActivity.kt
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/authentication/LoginActivity.kt Outdated
Comment thread owncloudApp/src/main/res/values/setup.xml
Comment thread ...d/android/data/authentication/datasources/implementation/OCRemoteAuthenticationDataSource.kt
Comment thread ...n/java/com/owncloud/android/data/oauth/datasources/implementation/OCRemoteOAuthDataSource.kt Outdated
Comment thread .../owncloud/android/data/server/datasources/implementation/OCRemoteServerInfoDataSourceTest.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/authentication/LoginActivity.kt
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/authentication/LoginActivity.kt
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/authentication/LoginActivity.kt
@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Jul 14, 2025

Some comments @joragua , tiny details. The PR is good-shaped 😄

@joragua joragua requested a review from jesmrec July 14, 2025 11:34
jesmrec
jesmrec requested changes Jul 14, 2025
View reviewed changes
Comment thread owncloudApp/src/main/res/values/setup.xml
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/authentication/LoginActivity.kt Outdated
Comment thread ...n/java/com/owncloud/android/data/oauth/datasources/implementation/OCRemoteOAuthDataSource.kt Outdated
@joragua joragua requested a review from jesmrec July 14, 2025 12:32
@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Jul 14, 2025

CR passed ✅ !! good job, @joragua. Let's go for the QA.

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Jul 15, 2025 •
edited
Loading

QA checks

  • oC
    • Basic
    • OAuth2 - authorization
    • OAuth2 - renewal
    • OIDC - authorization
    • OIDC - renewal
  • Kws
    • OAuth2 - authorization
    • OAuth2 - renewal

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Jul 15, 2025

Approved on my side. Ready to support both backends at the time!

joragua added 12 commits July 15, 2025 13:27
@joragua
feat: create new set of configurations for Kiteworks in setup.xml
2d02747
@joragua
feat: adapt authentication flow to the new setup for Kiteworks servers
5f6498b
@joragua
fix: handle /kwdav prefix correctly when attaching account to OwnClou…
245cb43 
…dClient
@joragua
refactor: use descriptive name for AccountsManager variable in OwnClo…
9f22c50 
…udAccount
@joragua
feat: adapt token renewal process to the new setup for Kiteworks servers
d77c66f
@joragua
test: update tests and add new ones for new Kiteworsk setup logic
2eb7dee
@joragua
chore: add calens file
33d40ca
@joragua
fix: set the correct client_id and client_secret in LoginActivity for…
2439277 
… Kiteworks servers
@joragua
feat: add redirect scheme and host variables for Kiteworks servers
77fdb2b
@joragua
test: remove an unnecessary check in one method from OCRemoteServerIn…
5935fdc 
…foDataSourceTest
@joragua
refactor: kotlinize the logic from performOIDCDiscovery method
f7215e8
@joragua
style: add a comment before the new configuration for Kiteworks servers
9fabf2d
@joragua joragua force-pushed the feature/new_setup_for_kiteworks_servers branch from e687d8e to 9fabf2d Compare July 15, 2025 11:28
@joragua joragua merged commit f9bfeef into master Jul 15, 2025
9 checks passed
@joragua joragua deleted the feature/new_setup_for_kiteworks_servers branch July 15, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels

Approved by qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Create new set of configurations for Kiteworks servers in setup.xml

3 participants

@joragua @jesmrec @ownclouders