[FEATURE REQUEST] Allow to go to the destination folder when the copy/move operation is finished by mykh-hailo · Pull Request #4802 · owncloud/android

mykh-hailo · 2026-03-11T03:27:27Z

Related Issues

Add changelog files for the fixed issues in folder changelog/unreleased. More info here
Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Reports

(1) Bottom bar changes [FEATURE REQUEST] Allow to go to the destination folder when the copy/move operation is finished #4802 (comment)
(2) Handle kind of item and plurality [FEATURE REQUEST] Allow to go to the destination folder when the copy/move operation is finished #4802 (comment)

joragua · 2026-03-11T09:47:33Z

Thanks for your contribution @mykh-hailo! 🍻 Just a small note before the CR: please be careful with the branch name. The branch prefixes we use in the project are: feature/, fix/ , technical/ and improvement/. Do not forget to take a look to CONTRIBUTING.md to make sure everything follows the guidelines.

I will take care of this as soon as possible and I'll ping you when it's ready 😄

mykh-hailo · 2026-03-12T11:56:15Z

@joragua I'd appreciate it if you share any feedback on the result.

mykh-hailo · 2026-03-13T11:37:22Z

@joragua Can you check my PR please?

joragua · 2026-03-16T10:07:56Z

@mykh-hailo I'll ping you when the CR is finished. Stay tuned! 😄

mykh-hailo · 2026-03-18T22:04:05Z

@joragua Can you provide me any updates on this?
I like your fast feedback and update.
😄

joragua · 2026-03-20T13:53:18Z

Hi @mykh-hailo! I'm working on the PR but it will not be available until next week. I'll ping you once it's done. No worries! 😄 Thanks for your patience!

joragua

Nice job @mykh-hailo! 🙌🏻 Somme comments here.

NOTE: I'd add a release note since this is an important and useful improvement for end users. They should be aware of it this and see the new feature in the release notes screen. You can add a new entry in ReleaseNotesViewModel.kt with an appropriate title and subtitle. Let us know if you have any question about this process. 😄

owncloudApp/src/main/java/com/owncloud/android/extensions/ActivityExt.kt

owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

owncloudApp/src/main/res/values/strings.xml

mykh-hailo · 2026-03-23T15:44:01Z

@joragua Thank you for your feedback.
I updated the code for it.
Could you check it please?

joragua

Some comments and it's ready @mykh-hailo! 😄

We usually use refactor: prefix in commits when we change the code but keep the same behavior (string changes, method refactoring...) We use the prefix fix: when something is broken and we must fix it. My suggestion: refactor: update string resource
The prefix used for release note is feat: since it's a new improvement in the app that end users can see. My suggestion: feat: add release note

You can do an interactive rebase and change the name of the commits applying my suggestions, in order to follow the project convention for commits. Let us know if you have any question about the process 🍻

...loudApp/src/main/java/com/owncloud/android/presentation/files/details/FileDetailsFragment.kt

owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

owncloudApp/src/main/res/values/strings.xml

mykh-hailo · 2026-03-30T13:36:34Z

@jesmrec @joragua
Could you possibly provide me any updates on my PR please?

joragua · 2026-03-30T14:31:29Z

Did you update the release note strings as @jesmrec suggested? I think with that change, it's ready to go 😄

mykh-hailo · 2026-03-30T16:06:30Z

@joragua Yes, I updated the release not strings. You can see them on the Changed file list.

joragua · 2026-03-30T16:12:43Z

But it's not the final version, right? @mykh-hailo 🤔 The release note we suggested was in #4802 (comment)

<string name="release_notes_4_8_0_title_action_to_copy_or_move_destination_folder">Navigation to target folder</string>
<string name="release_notes_4_8_0_subtitle_action_to_copy_or_move_destination_folder">New action to navigate to the destination folder when a file or folder is copied or moved<</string>

mykh-hailo · 2026-03-30T16:24:05Z

@joragua I am sorry for missing that. I made my updates.

joragua

LGTM! Let's QA this 🚀

Checklist for QA:

Re-login snackbar when session expires
Three-dot menu button not available in folder picker mode
Navigation to the target folder after move/copy operations

mykh-hailo · 2026-04-01T06:59:44Z

@jesmrec Can you provide me any updates on this PR?
Thank you.

jesmrec · 2026-04-01T07:19:26Z

@mykh-hailo i will provide you feedback as soon as posible, take some patience 😄 your contributions are pretty welcome, but they are not the only ones!!

mykh-hailo · 2026-04-07T13:42:25Z

@jesmrec I'd appreciate it if you have any chance to check my PR.

jesmrec · 2026-04-07T14:36:45Z

@mykh-hailo It will happen very very soon. Last days we had some problems with CI system that required full attention. Keep tuned, i will review very soon.

jesmrec · 2026-04-07T16:10:59Z

Starting QA here...

jesmrec · 2026-04-08T06:48:31Z

jesmrec · 2026-04-08T08:13:21Z

(1)

Check the following steps out:

In any custom space (not personal), select any item to copy
Select as target folder, any location in the Personal space
Submit the copy operation
In the snackbar, click on OPEN FOLDER

Current:

Spaces highlighted in bottom bar

Expected:

Personal highlighted in bottom bar

NOTE: same behaviour by copying from Personal to another custom space

Xiaomi Redmi Note 13, Android 15

mykh-hailo · 2026-04-08T08:43:15Z

@joragua , @jesmrec .
I update the code for the bottom bar highlight on snack bar actions.
I updated onCurrentFolderUpdated function from FileDisplayActivity to update the bottom bar selection.
I'd appreciate it if you provide me any feedback on it.

joragua

I've reviewed the code for the fix @mykh-hailo. Could you take a look at the comments that I've posted below? 😄 Thanks for your engagement!

owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

mykh-hailo · 2026-04-08T11:28:41Z

@joragua thanks for your comment.
Could you please check my updates and provide me any idea?

joragua · 2026-04-08T11:48:25Z

Could you check the unresolved comment above? @mykh-hailo Thanks! 🙌🏻

jesmrec · 2026-04-08T15:07:23Z

@mykh-hailo @joragua after your interesting conversation, i tested the solution with a mini checklist:

Check bottom bar's highlighted tab when copying from ... to ... :

root personal -> root space ✅
root personal -> no root space ❌
no root personal -> root space ✅
no root personal -> no root space ❌
root space -> root personal ✅
root space -> no root personal ✅
no root space -> root personal ✅
no root space -> no root personal ✅

that means, when copying something from Personal to any subfolder inside other space , the highlighted tab does not change.

could you take a look?

jesmrec · 2026-04-08T15:17:05Z

(2)

This is an small glitch, let me know if it could be fixed:

When some files are copied/moved by using the multiselection, the snackbar shows

File copied correctly
File moved correctly

that only matches in case of a singular file

We should handle the cases of several items, including folders. Different ideas that come to my head:

Replace File... with Item(s)... (it covers files, folders, singular and plural). Simplest solution.
Mind plurals as separate resources, i guess that Android allows that (more work?)
Check which kind/amount of items are being copied/moved and adapt the message to it like File copied correctly, Files copied correctly, Folder moved correctly, Folders moved correctly ... (more logic, it might not worth)

What do you think? does it make sense? any other idea?

mykh-hailo · 2026-04-08T15:35:46Z

@jesmrec Thanks for the catch.
We can handle plurals for multiple items.
But handling with different string for different types would be tricky.
Here is some scenarios:

Single file: File copied correctly.
Multiple files: x Files copied correctly.
Single folder: Folder copied correctly.
Multiple folders: x Folders copied correctly.
Multiple files+folders: x Items copied correct.

Do you like this idea?

jesmrec · 2026-04-08T15:59:27Z

@mykh-hailo i like the idea, sure. Please mind how difficult could be.

OTOH, we noticed only one commit in the PR. It's better to have separated commits for separated tasks as you set before the latest commit. Could you go back to that?

mykh-hailo · 2026-04-08T16:07:34Z

@mykh-hailo i like the idea, sure. Please mind how difficult could be.

OTOH, we noticed only one commit in the PR. It's better to have separated commits for separated tasks as you set before the latest commit. Could you go back to that?

Actually, it's not that difficult to update the code.
Just add some logic to count the number of files and folders to copy/move.
One thing to consider in testing is when handling conflict files or folders.
Meaning, if you copy/move 3 conflict files but skipped 1 file, should show 2 files copied correctly.

Btw, I will make separate commits for them.

…le type.

mykh-hailo · 2026-04-08T16:42:12Z

@jesmrec I made some updates for multiple and different selections.
Could you review it please?

mykh-hailo force-pushed the feat/copy_snack_bar branch 2 times, most recently from b088f36 to 9a416e0 Compare March 11, 2026 03:46

joragua linked an issue Mar 11, 2026 that may be closed by this pull request

[FEATURE REQUEST] Allow to go to the destination folder when the copy/move operation is finished #4379

Open

10 tasks

joragua requested changes Mar 23, 2026

View reviewed changes

mykh-hailo force-pushed the feat/copy_snack_bar branch 2 times, most recently from d886716 to a2d1b92 Compare March 23, 2026 14:27

mykh-hailo requested a review from joragua March 24, 2026 07:07

This comment was marked as outdated.

Sign in to view

joragua requested changes Mar 26, 2026

View reviewed changes

mykh-hailo force-pushed the feat/copy_snack_bar branch 2 times, most recently from c394298 to 2468ae7 Compare March 26, 2026 12:46

mykh-hailo requested review from jesmrec and joragua March 26, 2026 12:48

joragua approved these changes Mar 31, 2026

View reviewed changes

joragua requested changes Apr 8, 2026

View reviewed changes

mykh-hailo force-pushed the feat/copy_snack_bar branch 2 times, most recently from b88cbfc to 96509b7 Compare April 8, 2026 11:28

mykh-hailo force-pushed the feat/copy_snack_bar branch from 96509b7 to 1e6d108 Compare April 8, 2026 15:23

mykh-hailo added 7 commits April 8, 2026 13:18

feat: snack bar to go to target folder on copy/move

ac49b59

chore: add changelog

1834391

fix: update snack bar to use extensions

ecbc84b

fix: remove 3-dot menu on picker mode

956c0f0

chore: add release note.

5e8ce7c

fix: update bottom bar selection on snack bar action

6925893

fix: handle different strings for multiple selection and different fi…

371dd54

…le type.

mykh-hailo force-pushed the feat/copy_snack_bar branch from 1e6d108 to 371dd54 Compare April 8, 2026 16:40

mykh-hailo requested a review from joragua April 8, 2026 16:42

Conversation

mykh-hailo commented Mar 11, 2026 • edited by jesmrec Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues

QA

Uh oh!

joragua commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mykh-hailo commented Mar 12, 2026

Uh oh!

mykh-hailo commented Mar 13, 2026

Uh oh!

joragua commented Mar 16, 2026

Uh oh!

mykh-hailo commented Mar 18, 2026

Uh oh!

joragua commented Mar 20, 2026

Uh oh!

joragua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mykh-hailo commented Mar 23, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

joragua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mykh-hailo commented Mar 30, 2026

Uh oh!

joragua commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mykh-hailo commented Mar 30, 2026

Uh oh!

joragua commented Mar 30, 2026

Uh oh!

mykh-hailo commented Mar 30, 2026

Uh oh!

joragua left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mykh-hailo commented Apr 1, 2026

Uh oh!

jesmrec commented Apr 1, 2026

Uh oh!

mykh-hailo commented Apr 7, 2026

Uh oh!

jesmrec commented Apr 7, 2026

Uh oh!

jesmrec commented Apr 7, 2026

Uh oh!

jesmrec commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jesmrec commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(1)

Uh oh!

mykh-hailo commented Apr 8, 2026

Uh oh!

joragua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mykh-hailo commented Apr 8, 2026

Uh oh!

mykh-hailo commented Mar 11, 2026 •

edited by jesmrec

Loading

joragua commented Mar 11, 2026 •

edited

Loading

joragua commented Mar 30, 2026 •

edited

Loading

joragua left a comment •

edited

Loading

jesmrec commented Apr 8, 2026 •

edited

Loading

jesmrec commented Apr 8, 2026 •

edited

Loading

jesmrec commented Apr 8, 2026 •

edited

Loading

jesmrec commented Apr 8, 2026 •

edited

Loading

jesmrec commented Apr 8, 2026 •

edited

Loading