fix(js-tests): fix test isolation bugs exposed by Jasmine 5 random ordering (#41616)

* fix(js-tests): fix test isolation bugs exposed by Jasmine 5 random ordering

Jasmine 5 runs tests in random order by default, which exposed several
pre-existing test isolation bugs where shared singleton state was left
dirty between tests.

Fixes:
- fileactionsmenuSpec.js: call OC.hideMenus() in afterEach to clear
  OC._currentMenu before calling menu.remove(), preventing a stale
  reference from triggering a double slideUp in subsequent tests

- files_sharing/appSpec.js: save and restore OCA.Files.fileActions in
  the 'file actions' describe's beforeEach/afterEach so that stale
  _onActionsUpdated handlers registered by OCA.Files.App (in files/appSpec.js)
  don't fire with fileList=null and cause infinite recursion

- systemtagsinfoviewSpec.js: reset allTagsCollection (OC.SystemTags.collection
  singleton) in beforeEach and afterEach of the 'events' describe, so that
  model mutations (e.g. set('name', 'test1_renamed')) don't persist into
  subsequent test suites

- systemtagsinputfieldSpec.js: call view.collection.reset() in both the
  'as admin' and 'as user' initSelection beforeEach blocks so that stale
  models with matching ids from prior tests are cleared before adding
  fresh testTags (Backbone.add silently ignores duplicate-id models)

All fixes verified with 25 consecutive successful karma runs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>

* chore(changelog): add entry for PR #41616

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>

---------

Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: DeepDiver1975

apps/files/tests/js/fileactionsmenuSpec.js

@@ -93,6 +93,7 @@ describe('OCA.Files.FileActionsMenu tests', function() {
 		fileActions = null;
 		fileList.destroy();
 		fileList = undefined;
+		OC.hideMenus();
 		menu.remove();
 		$('#dir, #permissions, #filestable').remove();
 	});

apps/files_sharing/tests/js/appSpec.js

@@ -58,14 +58,18 @@ describe('OCA.Sharing.App tests', function() {
 	});
 	describe('file actions', function() {
 		var oldLegacyFileActions;
+		var oldFileActions;
 
 		beforeEach(function() {
 			oldLegacyFileActions = window.FileActions;
 			window.FileActions = new OCA.Files.FileActions();
+			oldFileActions = OCA.Files.fileActions;
+			OCA.Files.fileActions = new OCA.Files.FileActions();
 		});
 
 		afterEach(function() {
 			window.FileActions = oldLegacyFileActions;
+			OCA.Files.fileActions = oldFileActions;
 		});
 		it('provides default file actions', function() {
 			_.each([fileListIn, fileListOut], function(fileList) {

apps/systemtags/tests/js/systemtagsinfoviewSpec.js

@@ -53,6 +53,7 @@ describe('OCA.SystemTags.SystemTagsInfoView tests', function() {
 		var allTagsCollection;
 		beforeEach(function() {
 			allTagsCollection = view._inputView.collection;
+			allTagsCollection.reset();
 
 			allTagsCollection.add([
 				{id: '1', name: 'test1'},
@@ -68,6 +69,9 @@ describe('OCA.SystemTags.SystemTagsInfoView tests', function() {
 			]);
 			view.render();
 		});
+		afterEach(function() {
+			allTagsCollection.reset();
+		});
 		it('add tag to list view', function() {
 			view.selectedTagsCollection.add([{id: '4', name: 'test4'}]);
 			expect(view.$el.find('.system-tag-list-item').length).toEqual(4);

changelog/unreleased/41616

@@ -0,0 +1,10 @@
+Bugfix: Fix JS test isolation bugs exposed by Jasmine 5 random test ordering
+
+Several JS test specs left shared singleton state dirty between tests,
+causing intermittent failures when Jasmine 5 ran tests in random order.
+Fixed OC._currentMenu leak in fileactionsmenuSpec, stale OCA.Files.fileActions
+reference causing infinite recursion in files_sharing/appSpec, and stale
+models in the OC.SystemTags.collection singleton in systemtagsinfoviewSpec
+and systemtagsinputfieldSpec.
+
+https://github.com/owncloud/core/pull/41616

core/js/tests/specs/systemtags/systemtagsinputfieldSpec.js

@@ -339,6 +339,7 @@ describe('OC.SystemTags.SystemTagsInputField tests', function() {
 					new OC.SystemTags.SystemTagModel({id: '3', name: 'test3', userAssignable: false, canAssign: false}),
 					new OC.SystemTags.SystemTagModel({id: '4', name: 'test4', userAssignable: false, canAssign: true})
 				];
+				view.collection.reset();
 			});
 			afterEach(function() {
 				fetchStub.restore();
@@ -522,6 +523,7 @@ describe('OC.SystemTags.SystemTagsInputField tests', function() {
 					new OC.SystemTags.SystemTagModel({id: '3', name: 'test3', userAssignable: false, canAssign: false}),
 					new OC.SystemTags.SystemTagModel({id: '4', name: 'test4', userAssignable: false, canAssign: true})
 				];
+				view.collection.reset();
 				view.render();
 			});
 			afterEach(function() {