Skip to content

Commit fcfcfc1

Browse files
DeepDiver1975claude
andcommitted
fix(js-tests): pin sinon to ^19.0.5 to restore fakeServer in browser
sinon v20.0.0 removed nise (the XHR simulation library) from its browser UMD bundle (pkg/sinon.js), causing sinon.fakeServer to be undefined. karma-jasmine-sinon injects pkg/sinon.js and relies on window.sinon.fakeServer, so every test using fakeServer.create() in specHelper.js fails. sinon v19.0.5 is the last version whose browser bundle still exports fakeServer. The broken bump to ^22.0.0 was introduced in commit aaf5f0d (dependabot bump #41548) without test validation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
1 parent 71a3b00 commit fcfcfc1

2 files changed

Lines changed: 56 additions & 5 deletions

File tree

build/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"karma-jasmine": "^1.1.2",
4545
"karma-jasmine-sinon": "^1.0.4",
4646
"karma-junit-reporter": "*",
47-
"sinon": "^22.0.0"
47+
"sinon": "^19.0.5"
4848
},
4949
"resolutions": {
5050
"socket.io-parser": "4.2.3",

build/yarn.lock

Lines changed: 55 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,6 @@
271271

272272
"@bower_components/underscore@jashkenas/underscore#1.13.8":
273273
version "1.13.8"
274-
uid "9374840c22e348083d0d072f30dc980622523259"
275274
resolved "https://codeload.github.com/jashkenas/underscore/tar.gz/9374840c22e348083d0d072f30dc980622523259"
276275

277276
"@bower_components/zxcvbn@dropbox/zxcvbn#4.4.2":
@@ -327,7 +326,14 @@
327326
dependencies:
328327
type-detect "4.0.8"
329328

330-
"@sinonjs/fake-timers@^15.4.0":
329+
"@sinonjs/fake-timers@^13.0.5":
330+
version "13.0.5"
331+
resolved "https://registry.yarnpkg.com/@sinonjs/fake-timers/-/fake-timers-13.0.5.tgz#36b9dbc21ad5546486ea9173d6bea063eb1717d5"
332+
integrity sha512-36/hTbH2uaWuGVERyC6da9YwGWnzUZXuPro/F2LfsdOsLnCojz/iSH8MxUt/FD2S5XBSVPhmArFUXcpCQ2Hkiw==
333+
dependencies:
334+
"@sinonjs/commons" "^3.0.1"
335+
336+
"@sinonjs/fake-timers@^15.1.1", "@sinonjs/fake-timers@^15.4.0":
331337
version "15.4.0"
332338
resolved "https://registry.yarnpkg.com/@sinonjs/fake-timers/-/fake-timers-15.4.0.tgz#5d40c151a9e66075fe4520bec40bccfe54931962"
333339
integrity sha512-DsG+8/LscQIQg68J6Ef3dv10u6nVyetYn923s3/sus5eaGfTo1of5WMZSLf0UJc9KDuKPilPH0UDJCjvNbDNCA==
@@ -342,6 +348,14 @@
342348
"@sinonjs/commons" "^3.0.1"
343349
type-detect "^4.1.0"
344350

351+
"@sinonjs/samsam@^8.0.1":
352+
version "8.0.3"
353+
resolved "https://registry.yarnpkg.com/@sinonjs/samsam/-/samsam-8.0.3.tgz#eb6ffaef421e1e27783cc9b52567de20cb28072d"
354+
integrity sha512-hw6HbX+GyVZzmaYNh82Ecj1vdGZrqVIn/keDTg63IgAwiQPO+xCz99uG6Woqgb4tM0mUiFENKZ4cqd7IX94AXQ==
355+
dependencies:
356+
"@sinonjs/commons" "^3.0.1"
357+
type-detect "^4.1.0"
358+
345359
"@socket.io/component-emitter@~3.1.0":
346360
version "3.1.2"
347361
resolved "https://registry.yarnpkg.com/@socket.io/component-emitter/-/component-emitter-3.1.2.tgz#821f8442f4175d8f0467b9daf26e3a18e2d02af2"
@@ -652,6 +666,11 @@ di@^0.0.1:
652666
resolved "https://registry.yarnpkg.com/di/-/di-0.0.1.tgz#806649326ceaa7caa3306d75d985ea2748ba913c"
653667
integrity sha512-uJaamHkagcZtHPqCIHZxnFrXlunQXgBOsZSUOWwFw31QJCAbyTBoHMW75YOTur5ZNx8pIeAKgf6GWIgaqqiLhA==
654668

669+
diff@^7.0.0:
670+
version "7.0.0"
671+
resolved "https://registry.yarnpkg.com/diff/-/diff-7.0.0.tgz#3fb34d387cd76d803f6eebea67b921dab0182a9a"
672+
integrity sha512-PJWHUb1RFevKCwaFA9RlG5tCd+FO5iRh9A8HEtkmBH2Li03iJriB6m6JIN4rGz3K3JLawI7/veA1xzRKP6ISBw==
673+
655674
diff@^9.0.0:
656675
version "9.0.0"
657676
resolved "https://registry.yarnpkg.com/diff/-/diff-9.0.0.tgz#297c31cd7c280f13dfe335791ec2063bd4a73a6f"
@@ -1037,6 +1056,11 @@ jsonfile@^4.0.0:
10371056
optionalDependencies:
10381057
graceful-fs "^4.1.6"
10391058

1059+
just-extend@^6.2.0:
1060+
version "6.2.0"
1061+
resolved "https://registry.yarnpkg.com/just-extend/-/just-extend-6.2.0.tgz#b816abfb3d67ee860482e7401564672558163947"
1062+
integrity sha512-cYofQu2Xpom82S6qD778jBDpwvvy39s1l/hrYij2u9AMdQcGRpaBu6kY4mVhuno5kJVi1DAz4aiphA2WI1/OAw==
1063+
10401064
karma-coverage@*:
10411065
version "2.2.1"
10421066
resolved "https://registry.yarnpkg.com/karma-coverage/-/karma-coverage-2.2.1.tgz#e1cc074f93ace9dc4fb7e7aeca7135879c2e358c"
@@ -1238,6 +1262,16 @@ neo-async@^2.6.2:
12381262
resolved "https://registry.yarnpkg.com/neo-async/-/neo-async-2.6.2.tgz#b4aafb93e3aeb2d8174ca53cf163ab7d7308305f"
12391263
integrity sha512-Yd3UES5mWCSqR+qNT93S3UoYUkqAZ9lLg8a7g9rimsWmYGK8cVToA4/sF3RrshdyV3sAGMXVUmpMYOw+dLpOuw==
12401264

1265+
nise@^6.1.1:
1266+
version "6.1.5"
1267+
resolved "https://registry.yarnpkg.com/nise/-/nise-6.1.5.tgz#a2f4cd07d8d38ebc5ae5500168eea0f08a2fa4b9"
1268+
integrity sha512-SnRDPDBjxZZoU2n0+gzzLtSvo1OZo7j6jnbXsoh3AFxEGhaFU7ZF0TmefuKERq79wxR2U+MPn7ArW+Tl+clC3A==
1269+
dependencies:
1270+
"@sinonjs/commons" "^3.0.1"
1271+
"@sinonjs/fake-timers" "^15.1.1"
1272+
just-extend "^6.2.0"
1273+
path-to-regexp "^8.3.0"
1274+
12411275
node-releases@^2.0.14:
12421276
version "2.0.14"
12431277
resolved "https://registry.yarnpkg.com/node-releases/-/node-releases-2.0.14.tgz#2ffb053bceb8b2be8495ece1ab6ce600c4461b0b"
@@ -1303,6 +1337,11 @@ path-is-absolute@^1.0.0:
13031337
resolved "https://registry.yarnpkg.com/path-is-absolute/-/path-is-absolute-1.0.1.tgz#174b9268735534ffbc7ace6bf53a5a9e1b5c5f5f"
13041338
integrity sha512-AVbw3UJ2e9bq64vSaS9Am0fje1Pa8pbGqTTsmXfaIiMpnr5DlDhfJOuLj9Sf95ZPVDAUerDfEk88MPmPe7UCQg==
13051339

1340+
path-to-regexp@^8.3.0:
1341+
version "8.4.2"
1342+
resolved "https://registry.yarnpkg.com/path-to-regexp/-/path-to-regexp-8.4.2.tgz#795c420c4f7ca45c5b887366f622ee0c9852cccd"
1343+
integrity sha512-qRcuIdP69NPm4qbACK+aDogI5CBDMi1jKe0ry5rSQJz8JVLsC7jV8XpiJjGRLLol3N+R5ihGYcrPLTno6pAdBA==
1344+
13061345
picocolors@^1.0.0, picocolors@^1.0.1:
13071346
version "1.0.1"
13081347
resolved "https://registry.yarnpkg.com/picocolors/-/picocolors-1.0.1.tgz#a8ad579b571952f0e5d25892de5445bcfe25aaa1"
@@ -1417,7 +1456,7 @@ signal-exit@^3.0.2:
14171456
resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.7.tgz#a9a1767f8af84155114eaabd73f99273c8f59ad9"
14181457
integrity sha512-wnD2ZE+l+SPC/uoS0vXeE9L1+0wuaMqKlfz9AMUo38JsyLSBWSFcHR1Rri62LZc12vLr1gb3jl7iwQhgwpAbGQ==
14191458

1420-
"sinon@>= 1.7.1", sinon@^22.0.0:
1459+
"sinon@>= 1.7.1":
14211460
version "22.0.0"
14221461
resolved "https://registry.yarnpkg.com/sinon/-/sinon-22.0.0.tgz#01cea95c919468f6ef01e21d406397e5c02aad9b"
14231462
integrity sha512-sq/6DpdXOrLyfbKlXLg/Usc7xu8YXPeLkOFZRvA3bNUSA2lhbrZ06yuXbH1fkzBPCbz9O10+7hznzUsjaYNm0Q==
@@ -1427,6 +1466,18 @@ signal-exit@^3.0.2:
14271466
"@sinonjs/samsam" "^10.0.2"
14281467
diff "^9.0.0"
14291468

1469+
sinon@^19.0.5:
1470+
version "19.0.5"
1471+
resolved "https://registry.yarnpkg.com/sinon/-/sinon-19.0.5.tgz#64fd2f84786a043f721246c40b36bef4c4b76b3c"
1472+
integrity sha512-r15s9/s+ub/d4bxNXqIUmwp6imVSdTorIRaxoecYjqTVLZ8RuoXr/4EDGwIBo6Waxn7f2gnURX9zuhAfCwaF6Q==
1473+
dependencies:
1474+
"@sinonjs/commons" "^3.0.1"
1475+
"@sinonjs/fake-timers" "^13.0.5"
1476+
"@sinonjs/samsam" "^8.0.1"
1477+
diff "^7.0.0"
1478+
nise "^6.1.1"
1479+
supports-color "^7.2.0"
1480+
14301481
socket.io-adapter@~2.5.2:
14311482
version "2.5.4"
14321483
resolved "https://registry.yarnpkg.com/socket.io-adapter/-/socket.io-adapter-2.5.4.tgz#4fdb1358667f6d68f25343353bd99bd11ee41006"
@@ -1517,7 +1568,7 @@ supports-color@^5.3.0:
15171568
dependencies:
15181569
has-flag "^3.0.0"
15191570

1520-
supports-color@^7.1.0:
1571+
supports-color@^7.1.0, supports-color@^7.2.0:
15211572
version "7.2.0"
15221573
resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-7.2.0.tgz#1b7dcdcb32b8138801b3e478ba6a51caa89648da"
15231574
integrity sha512-qpCAvRl9stuOHveKsn7HncJRvv501qIacKzQlO/+Lwxc9+0q2wLyv4Dfvt80/DPn2pqOBsJdDiogXGR9+OvwRw==

0 commit comments

Comments
 (0)