chore: update translations from transifex#41627
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated review by Claude Code review agent.
Overview
Auto-generated Transifex translation update (owncloud-translations-bot). Adds a single new Albanian (sq) translation string to apps/files_external/l10n/sq.js and apps/files_external/l10n/sq.json. Net change: +2 lines, 0 deletions, 2 files.
The new entry translates:
"Storage connection error. See server log for details."→"Gabim lidhjeje me depozitën. Për hollësi shihni regjistër shërbyesi."
Code quality / style
- Both the
.jsand.jsonvariants are updated in lockstep with identical key/value pairs, which is the expected convention for ownCloud l10n files. Good. - The new line is inserted in the same position in both files, preserving ordering consistency.
- Formatting (quoting, spacing,
" : "separator) matches the surrounding entries.
Specific suggestions
None. This is generated content and should not be hand-edited.
Potential issues / risks
- Low risk. Purely additive translation data — no executable code, no schema or API changes.
- No placeholder/format-specifier mismatch: the source string contains no
%s/%dtokens, and the translation correctly omits them too, so there is no risk ofprintf-style formatting breakage. - No unescaped quotes or structural JSON concerns in the added line.
- Nothing anomalous detected (no unexpected files, no binary blobs, no key collisions).
Recommendation: safe to merge as routine automated translation content.
592c42b to
a2e067c
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated review by Claude Code review agent.
Overview
This is an automated translation update from Transifex (authored by the owncloud-translations-bot). It adds a single Albanian (sq) string for the files_external app: a translation of "Storage connection error. See server log for details.". The change touches two files (apps/files_external/l10n/sq.js and apps/files_external/l10n/sq.json) with one identical added line in each — 2 additions, 0 deletions. This is low-risk, machine-generated translation content.
Code quality / style
- The new entry is consistent with the surrounding translation entries in both files (same key/value format, indentation, and trailing comma).
- The same source string is added to both the JS (
OC.L10N.register(...)) and JSON variants with matching key and translation, which is the expected pairing for ownCloud l10n files.
Specific suggestions
- None. The content is auto-generated and formatted correctly.
Potential issues / risks
- No malformed JSON/JS detected; the added line follows the existing comma-terminated pattern and quoting/escaping is correct.
- No suspicious non-translation changes — the diff is purely the addition of one localized string. Nothing anomalous.
Approving as routine, low-risk automated localization content.
a2e067c to
de4fd27
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated review by Claude Code review agent.
Overview
Automated Transifex translation sync (by owncloud-translations-bot). The diff is minimal: 2 files changed, 2 additions, 0 deletions. Both files are the Albanian (sq) locale for the files_external app:
apps/files_external/l10n/sq.jsapps/files_external/l10n/sq.json
A single new string is added to each: "Storage connection error. See server log for details." → "Gabim lidhjeje me depozitën. Për hollësi shihni regjistër shërbyesi."
This is low-risk, machine-generated translation content.
Code quality / style
- Both additions match the existing indentation and
"key" : "value"formatting of surrounding lines. - The
.jsentry sits inside theOC.L10N.register(...)object and the.jsonentry inside the JSON object; both keep the trailing-comma convention used throughout the files, so neither breaks JS/JSON parsing. - The
.jsand.jsonfiles stay in sync — the same key/value pair is added to both, as expected for these paired l10n artifacts.
Specific suggestions
None. No actionable changes for generated translation strings.
Potential issues / risks
- No format placeholders (
%s,%d,%i) appear in this source string, and none were introduced in the translation, so there is no placeholder-mismatch risk. - No non-translation files are touched; nothing outside
l10n/is modified. - No malformed JSON/JS detected; diff is purely additive.
Looks good to merge from a review standpoint.
de4fd27 to
8146514
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated review by Claude Code review agent.
Overview
Automated Transifex translation sync (PR by owncloud-translations-bot). 6 files changed, +10/-0, all under apps/files_external/l10n/: paired .js/.json files for pt_BR, pt_PT, and sq. New strings added: "Storage connection error. See server log for details." (all three locales) and "Storage with id \"%d\" not found" (pt_BR, pt_PT). Purely generated translation content — low risk.
Code quality / style
- Changes are additive only (no deletions, no reordering).
.jsand.jsonpairs are consistent with each other per locale.- No non-translation files touched; structure matches existing
OC.L10N.register(...)/ JSON map conventions. JSON/JS appears well-formed.
Specific suggestions
- pt_PT placeholder corruption (please fix upstream in Transifex): The pt_PT translation for
"Storage with id \"%d\" not found"is"Armazenamento com ID \"1%d\" não encontrado"— note the stray leading1before the%dplaceholder (\"1%d\"). Compare pt_BR which correctly uses\"%d\". This will render an extraneous1in front of the storage id at runtime. Worth correcting in the Transifex source string so the next sync clears it.
Potential issues / risks
- Low risk overall — generated translation strings, no code paths affected.
- The only substantive concern is the pt_PT
\"1%d\"artifact noted above (cosmetic/runtime display, not a crash). Placeholder token%ditself is preserved, so no format-specifier mismatch that would break the formatting call. - No malformed JSON/JS or unexpected files detected.
Approving in spirit as low-risk automated content; recommend the pt_PT string fix upstream.
ef14508 to
b538162
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated code review by Claude Code review agent
Routine translations sync from Transifex. Scope looks correct — all 22 changed files are l10n translation resources (.js/.json under apps/files_external/l10n/ and lib/l10n/), 42 additions / 0 deletions, no source-code, config, or logic changes. Sampled JSON/JS entries are well-formed.
Non-blocking nit (translator content, not a blocker for an automated sync): in apps/files_external/l10n/pt_PT.{js,json}, the value for "Storage with id \"%d\" not found" is "Armazenamento com ID \"1%d\" não encontrado" — a stray 1 before the %d placeholder (likely a Transifex source typo). Worth fixing upstream in Transifex.
LGTM as a translations update.
b538162 to
5b3d49f
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated review by Claude Code review agent.
Scope: Automated Transifex translation sync. All 22 changed files are l10n resource files (.js/.json) under apps/files_external/l10n/ and lib/l10n/ — 42 additions, 0 deletions, no source or logic changes. New strings cover storage-connection error messages and the group-admin (subadmin) feature notice across en_GB, en_US, es, pt_BR, pt_PT, and sq.
Checks: All required checks green (PHP Unit matrix, JS Unit, API/CLI smoke tests, code style, lint, CodeQL, semantic-commit + Changelog lint all pass). mergeStateStatus=BLOCKED reflects the pending required review, not a merge conflict (mergeable=MERGEABLE).
Changelog: n/a by convention. ownCloud core does not ship a changelog fragment for Transifex translation syncs — confirmed against recently merged translation-bot PRs (#41537, #41528), neither of which added a changelog entry, and the "Changelog lint" check passes here. No changelog entry is needed.
Nit (translator data, not actionable here): In apps/files_external/l10n/pt_PT.{js,json} the new string Storage with id "%d" not found is translated with a stray literal 1 in the placeholder: Armazenamento com ID "1%d" não encontrado. This originates upstream in Transifex and should be corrected there rather than in this auto-generated PR.
Verdict: looks good — a clean, routine translation update. (Review-only; not approving/merging.)
5b3d49f to
56a4e92
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
Routine Transifex translation sync — l10n-only (22 files, all under l10n/, no code paths touched), consistent with prior merged translation updates (#41537, #41528). All required checks green, MERGEABLE, no changelog fragment needed (translation chores don't carry one in this repo). Zero reservations.
Automated translation update from Transifex. This pull request is updated on each sync run — merging it will close it and a fresh one will be opened on the next change.