Skip to content

Commit 6aa1c1e

Browse files
authored
Merge pull request #913 from owncloud/align_pack_command_to_build
Align the options of gulp.src to the bundle command
2 parents 77b652d + 3c82086 commit 6aa1c1e

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

tasks/build.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ module.exports = (src, dest) => {
9292
gulp.src('partials/*.hbs', opts),
9393

9494
// encoding: false == avoid any transcoding, and effectively just pass around raw binary data.
95-
// if omitted, mage files such as .png will be transcoded and become useless
95+
// if omitted, image files such as .png will be transcoded and become useless
9696
gulp.src('static/**/*', { ...opts, base: path.join(src, 'static'), dot: true, encoding: false }),
9797

9898
gulp.src('ui.yml', { ...opts, allowEmpty: true })

tasks/pack.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ module.exports = (src, dest, bundleName) =>
1313
}
1414

1515
gulp
16-
.src('**/*', { base: src, cwd: src })
16+
// encoding: false == avoid any transcoding, and effectively just pass around raw binary data.
17+
// if omitted, image files such as .png will be transcoded and become useless
18+
.src('**/*', { base: src, cwd: src, dot: true, encoding: false })
1719
.pipe(zip(`${bundleName}-bundle.zip`))
1820
.pipe(gulp.dest(dest))
1921
.on('end', function () {

0 commit comments

Comments
 (0)